From: Antonio Quartulli <ordex@autistici.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: properly push NET_IP_ALIGN bytes more
Date: Tue, 2 Apr 2013 17:19:31 +0200 [thread overview]
Message-ID: <20130402151930.GL4024@ritirata.org> (raw)
In-Reply-To: <1364903975-7141-1-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Tue, Apr 02, 2013 at 01:59:35PM +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
>
> every batman-adv encapsulated packet is supposed to begin
> with an Ethernet header plus 2 bytes for correct alignment
> on 4 bytes boundary.
>
> However, even if allocations are made correctly, the final
> encapsulation is not made properly since the encapsulating
> function does not push NET_IP_ALIGN bytes other than
> ETH_HLEN.
>
> Fix it by pushing the correct amount of bytes.
>
> Introduced by 7f91790974c258e71a62f6dee8cb1dbe5dff36c3
> ("batman-adv: Reserve extra bytes in skb for better alignment")
>
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
This patch can be dropped.
We don't want to send those two extra bytes, we use them only for local memory
alignment.
Sorry about that.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-04-02 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:59 [B.A.T.M.A.N.] [PATCH maint] batman-adv: properly push NET_IP_ALIGN bytes more Antonio Quartulli
2013-04-02 15:19 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402151930.GL4024@ritirata.org \
--to=ordex@autistici.org \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox