From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: tcpdump - print subtype for UNICAST4ADDR packets
Date: Tue, 2 Apr 2013 16:41:31 +0800 [thread overview]
Message-ID: <201304021641.31457.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1364760198-17043-2-git-send-email-ordex@autistici.org>
On Monday, April 01, 2013 04:03:18 Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> tcpdump.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tcpdump.c b/tcpdump.c
> index 39239dd..bf4edd4 100644
> --- a/tcpdump.c
> +++ b/tcpdump.c
> @@ -562,7 +562,8 @@ static void dump_batman_4addr(unsigned char
> *packet_buff, ssize_t buff_len, int
>
> printf("%s: 4ADDR, subtype %d, ttvn %d, ttl %hhu, ",
> get_name_by_macaddr((struct ether_addr *)unicast_4addr_packet->u.dest, read_opt),
> - unicast_4addr_packet->u.ttvn, unicast_4addr_packet->u.header.ttl);
> + unicast_4addr_packet->subtype, unicast_4addr_packet->u.ttvn,
> + unicast_4addr_packet->u.header.ttl);
>
You added the subtype printf format string with the previous patch
already. You might want to fix this.
Cheers,
Marek
next prev parent reply other threads:[~2013-04-02 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 20:03 [B.A.T.M.A.N.] [PATCH 1/2] batctl: fix 4addr parsing in tcpdump Antonio Quartulli
2013-03-31 20:03 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: tcpdump - print subtype for UNICAST4ADDR packets Antonio Quartulli
2013-04-02 8:41 ` Marek Lindner [this message]
2013-04-02 13:41 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304021641.31457.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox