From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't initialise batman_iv private members in hard-interface.c
Date: Mon, 15 Apr 2013 17:27:35 +0800 [thread overview]
Message-ID: <201304151727.36146.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20130402102250.GJ4024@ritirata.org>
On Tuesday, April 02, 2013 18:22:50 Antonio Quartulli wrote:
> On Tue, Apr 02, 2013 at 12:16:53PM +0200, Antonio Quartulli wrote:
> > From: Antonio Quartulli <antonio@open-mesh.com>
> >
> >
> >
> > hard-interface.c has to do not contain any routing algorithm
> > specific code.
> >
> >
> >
> > Allocate the hard-interface with kzalloc() and remove any
> > useless and algorithm specific member initialisation
> >
> >
> >
> > Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> > ---
>
> For whoever is concerned about this missing initialisations, I have to say
> that those are done in the routing specific API function upon
> hard-interface activation. Meaning that the seqno and the ogm_buff are
> initialised somewhere else before being used.
>
> However, using kzalloc, ensure that all the members are initialised to 0
> after allocation.
Applied in revision 1cc6cbc.
Thanks,
Marek
prev parent reply other threads:[~2013-04-15 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 10:16 [B.A.T.M.A.N.] [PATCH] batman-adv: don't initialise batman_iv private members in hard-interface.c Antonio Quartulli
2013-04-02 10:22 ` Antonio Quartulli
2013-04-15 9:27 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304151727.36146.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox