public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: tvlv - convert tt query packet to use tvlv unicast packets
Date: Wed, 17 Apr 2013 00:59:02 +0800	[thread overview]
Message-ID: <201304170059.02745.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20130416164001.GC20819@ritirata.org>

On Wednesday, April 17, 2013 00:40:01 Antonio Quartulli wrote:
> On Tue, Apr 16, 2013 at 11:26:34PM +0800, Marek Lindner wrote:
> > Instead of generating TT specific packets the TVLV unicast API is used
> > to send translation table data.
> >
> > 
> >
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> 
> [...]
> 
> > -
> > -     if (batadv_send_skb_to_orig(skb, dst_orig_node, NULL))
> > -             ret = 0;
> > +     batadv_tvlv_unicast_send(bat_priv, primary_if->net_dev->dev_addr,
> > +                              dst_orig_node->orig, BATADV_TVLV_TT, 1,
> > +                              (unsigned char *)tvlv_tt_data,
> 
>                                  ^^^^^^^^^^^^^^^^^
> You should remove this cast since the function expects a void *

Thanks for the hint! I fixed the function calls and pushed the patches into my 
repository[1]. Feel free to pull from there.

Cheers,
Marek

[1] http://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/marek/tvlv

  reply	other threads:[~2013-04-16 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 15:26 [B.A.T.M.A.N.] TVLV infrastructure Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: tvlv - basic infrastructure Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: tvlv - convert gateway flags Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: tvlv - add distributed arp table container Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: tvlv - add network coding container Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: tvlv - convert tt data sent within OGMs Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: tvlv - convert tt query packet to use tvlv unicast packets Marek Lindner
2013-04-16 16:40   ` Antonio Quartulli
2013-04-16 16:59     ` Marek Lindner [this message]
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: tvlv - convert roaming adv " Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304170059.02745.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox