From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Thu, 18 Apr 2013 03:56:15 +0800 References: <1366227943-25134-1-git-send-email-ordex@autistici.org> In-Reply-To: <1366227943-25134-1-git-send-email-ordex@autistici.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201304180356.15905.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: fix global protection fault during soft_iface destruction Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org On Thursday, April 18, 2013 03:45:43 Antonio Quartulli wrote: > batadv_mesh_free() schedules some RCU callbacks which need the bat_priv > struct to do their jobs, while free_netdev(), which is called immediately > after, is destroying the private data. > > Put an rcu_barrier() in the middle so that free_netdev() is invoked only > after all the callbacks returned. > > This bug has been introduced by ab8f433dd39be94e8617cff2dfe9f7eca162eb15 > ("batman-adv: Move deinitialization of soft-interface to destructor") > > Signed-off-by: Antonio Quartulli > --- > > > soft-interface.c | 7 +++++++ > 1 file changed, 7 insertions(+) Applied in revision 73eb82e. Thanks, Marek