From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: use vid when computing local and global TT CRC
Date: Tue, 23 Apr 2013 22:04:34 +0200 [thread overview]
Message-ID: <20130423200434.GC16603@ritirata.org> (raw)
In-Reply-To: <201304240358.56353.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
On Wed, Apr 24, 2013 at 03:58:56AM +0800, Marek Lindner wrote:
> On Tuesday, April 23, 2013 22:34:30 Antonio Quartulli wrote:
> > @@ -1535,7 +1535,9 @@ static uint32_t batadv_tt_global_crc(struct
> > batadv_priv *bat_priv, orig_node)) continue;
> >
> > - crc ^= crc32c(0, tt_common->addr, ETH_ALEN);
> > + crc_tmp = crc32c(0, &tt_common->vid,
> > + sizeof(tt_common->vid));
> > + crc ^= crc32c(crc_tmp, tt_common->addr, ETH_ALEN);
> > }
> > rcu_read_unlock();
>
> Is it necessary to define another variable ?
yes
> Why not:
>
> crc = crc32c(0, &tt_common->vid, sizeof(tt_common->vid));
> crc ^= crc32c(crc, tt_common->addr, ETH_ALEN);
>
because crc_tmp is the result of the CRC operation on the VID and the MAC
address (so one per client), while crc is the container of all the crc_tmp
xor'ed together..
>
> > @@ -1565,7 +1567,9 @@ static uint32_t batadv_tt_local_crc(struct batadv_priv
> *bat_priv)
> > if (tt_common->flags & BATADV_TT_CLIENT_NEW)
> > continue;
> >
> > - crc ^= crc32c(0, tt_common->addr, ETH_ALEN);
> > + crc_tmp = crc32c(0, &tt_common->vid,
> > + sizeof(tt_common->vid));
> > + crc ^= crc32c(crc_tmp, tt_common->addr, ETH_ALEN);
> > }
>
> Dito.
Idem.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-23 20:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 14:34 [B.A.T.M.A.N.] [PATCH 0/7] make the Translation Table component VLAN-aware Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: add the VLAN ID attribute to the TT entry Antonio Quartulli
2013-05-04 12:39 ` Marek Lindner
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: use vid when computing local and global TT CRC Antonio Quartulli
2013-04-23 19:58 ` Marek Lindner
2013-04-23 20:04 ` Antonio Quartulli [this message]
2013-05-04 12:12 ` Marek Lindner
2013-05-04 12:17 ` Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: print the VID together with the TT entries Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: make the GW component vlan-featured Antonio Quartulli
2013-04-23 14:42 ` Antonio Quartulli
2013-05-04 12:42 ` Marek Lindner
2013-05-04 17:07 ` Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: make the GW module correctly talk to the new VLAN-TT Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: make the Distributed ARP Table vlan aware Antonio Quartulli
2013-05-06 3:31 ` Marek Lindner
2013-05-06 6:05 ` Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: add per VLAN interface attribute framework Antonio Quartulli
2013-04-24 12:31 ` Antonio Quartulli
2013-04-23 14:34 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: make the AP isolation attribute VLAN specific Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423200434.GC16603@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox