From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Mon, 29 Apr 2013 15:06:57 +0800 References: <1367050948-7626-1-git-send-email-lindner_marek@yahoo.de> <20130427160132.GA3179@ritirata.org> In-Reply-To: <20130427160132.GA3179@ritirata.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201304291506.57622.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: check proto length before accessing proto string buffer Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org Cc: Antonio Quartulli On Sunday, April 28, 2013 00:01:32 Antonio Quartulli wrote: > On Sat, Apr 27, 2013 at 04:22:28 +0800, Marek Lindner wrote: > > batadv_param_set_ra() strips the trailing '\n' from the supplied > > string buffer without checking the length of the buffer first. This > > patches avoids random memory access and associated potential > > crashes. > > > > > > > > Reported-by: Sasha Levin > > Signed-off-by: Marek Lindner > > Thank you for fixing this! > > Please, merge this patch in maint. Applied in revision aa7d19a. Regards, Marek