From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <ordex@autistici.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: use the BigEndian notation for variables sent over the wire
Date: Mon, 29 Apr 2013 15:10:01 +0800 [thread overview]
Message-ID: <201304291510.02220.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1367136566-12593-1-git-send-email-ordex@autistici.org>
On Sunday, April 28, 2013 16:09:26 Antonio Quartulli wrote:
> All the variables sent over the wire must report the
> BigEndian (__be*) notation so that sparse can easily spot
> any bug due to missing conversions.
>
> This patch changes the type used by the up and download
> bandwidth in the new GW TVLV from uint32_t to __be32 and
> adds all the related conversions.
>
> Introduced by: 0853ec7fafe0a195754454832993c6b35e22b842
> ("batman-adv: tvlv - gateway download/upload bandwidth container")
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>
> v1 was:
> batman-adv: properly handle Network Ordered variables
>
> v2:
> change subject and commit message
>
>
>
> gateway_client.c | 24 +++++++++++++-----------
> gateway_common.c | 4 ++--
> packet.h | 4 ++--
> 3 files changed, 17 insertions(+), 15 deletions(-)
Applied in revision b6acece.
Thanks,
Marek
prev parent reply other threads:[~2013-04-29 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 8:09 [B.A.T.M.A.N.] [PATCHv2] batman-adv: use the BigEndian notation for variables sent over the wire Antonio Quartulli
2013-04-29 7:10 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304291510.02220.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox