Re: [B.A.T.M.A.N.] [PATCH] Made DAT more generic by adding support to any type of data

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

On Fri, Apr 26, 2013 at 04:56:54 +0300, Mihail wrote:
> From: Mihail Costea <mihail.costea90@gmail.com>
> 
> Made DAT support more types by making its data a void*, adding type field
> to dat_entry and adding data_type to necessary functions.
> This change is needed in order to make DAT support any type of data, like IPv6 too.
> 
> Added generic function for transforming DAT data to string.
> The function is used in order to avoid defining different debug messages
> for different DAT data types. For example, if we had IPv6 as a DAT data,
> then "%pI4" should be "%pI6c", but all
> the other text of the debug message would be the same.
> 
> Signed-off-by: Mihail Costea <mihail.costea90@gmail.com>
> Signed-off-by: Stefan Popa <Stefan.A.Popa@intel.com>
> Reviewed-by: Stefan Popa <Stefan.A.Popa@intel.com>

Hi Mihail,

as discussed on IRC this patch is now pretty mature and looks very good!
Also other devs have read it and were happy about the work done so far.

However the idea is to wait and merge this patch together with the IPv6
mechanism, so that we don't only introduce this generalisation, but we also use
it (Bloating the kernel with something cool that is not exploited is not a good
idea..).

Hence we will be happy to to wait and review the IPv6 mechanism as soon as you
can send it over the ml.

While discussing this patch I imagine you learnt a lot of things which may
help you in polishing the code that is going to come :)


Let us know when the IPv6 part is ready to be reviewed! We are all eager to
introduce and use this new feature!


Cheers (have a nice Saturday),

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]