From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix VLAN Ethernet header access
Date: Thu, 9 May 2013 18:44:26 +0200 [thread overview]
Message-ID: <20130509164426.GF1415@ritirata.org> (raw)
In-Reply-To: <201305100007.08742.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Fri, May 10, 2013 at 12:07:08AM +0800, Marek Lindner wrote:
> On Thursday, May 09, 2013 22:16:49 Antonio Quartulli wrote:
> > From: Antonio Quartulli <antonio@open-mesh.com>
> >
> > In interface_rx() skb->data cannot be directly used to
> > access the Ethernet header because it point to the batman
> > one.
>
> You don't believe that these calls (shortly before the code chunks you are
> changing) are helpful ?
>
> skb_pull_rcsum(skb, hdr_size);
> skb_reset_mac_header(skb);
You are right. Hence this is not fixing anything. It is just a beautification
and therefore we don't need it in maint.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-09 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 14:16 [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix VLAN Ethernet header access Antonio Quartulli
2013-05-09 16:07 ` Marek Lindner
2013-05-09 16:44 ` Antonio Quartulli [this message]
2013-05-10 3:37 ` Marek Lindner
2013-05-10 6:16 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509164426.GF1415@ritirata.org \
--to=ordex@autistici.org \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox