From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH next 1/2] batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK
Date: Thu, 9 May 2013 18:45:04 +0200 [thread overview]
Message-ID: <20130509164504.GG1415@ritirata.org> (raw)
In-Reply-To: <201305100009.11734.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
On Fri, May 10, 2013 at 12:09:11AM +0800, Marek Lindner wrote:
> On Thursday, May 09, 2013 22:28:06 Antonio Quartulli wrote:
> > --- a/main.h
> > +++ b/main.h
> > @@ -172,8 +172,6 @@ enum batadv_vlan_flags {
> > BATADV_VLAN_HAS_TAG = BIT(15),
> > };
> >
> > -/* mask needed to extract the vlan ID (12bits) from a 16bits variable */
> > -#define BATADV_VID_MASK 0x0FFF
> > #define BATADV_PRINT_VID(vid) (vid & BATADV_VLAN_HAS_TAG ? \
> > (int)(vid & BATADV_VID_MASK) : -1)
>
> The last user should remove the define otherwise the code won't compile.
oh, ok, will send v2 with the patches in the other order.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-09 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 14:28 [B.A.T.M.A.N.] [PATCH next 1/2] batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK Antonio Quartulli
2013-05-09 14:28 ` [B.A.T.M.A.N.] [PATCH next 2/2] batman-adv: use VLAN_VID_MASK when printing the vid Antonio Quartulli
2013-05-09 16:09 ` [B.A.T.M.A.N.] [PATCH next 1/2] batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK Marek Lindner
2013-05-09 16:45 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509164504.GG1415@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox