From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Fri, 10 May 2013 00:09:11 +0800 References: <1368109687-3780-1-git-send-email-ordex@autistici.org> In-Reply-To: <1368109687-3780-1-git-send-email-ordex@autistici.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201305100009.11734.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH next 1/2] batman-adv: use VLAN_VID_MASK instead of BATADV_VID_MASK Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Thursday, May 09, 2013 22:28:06 Antonio Quartulli wrote: > --- a/main.h > +++ b/main.h > @@ -172,8 +172,6 @@ enum batadv_vlan_flags { > BATADV_VLAN_HAS_TAG = BIT(15), > }; > > -/* mask needed to extract the vlan ID (12bits) from a 16bits variable */ > -#define BATADV_VID_MASK 0x0FFF > #define BATADV_PRINT_VID(vid) (vid & BATADV_VLAN_HAS_TAG ? \ > (int)(vid & BATADV_VID_MASK) : -1) The last user should remove the define otherwise the code won't compile. Cheers, Marek