Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix VLAN Ethernet header access

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Fri, May 10, 2013 at 11:37:55AM +0800, Marek Lindner wrote:
> On Friday, May 10, 2013 00:44:26 Antonio Quartulli wrote:
> >   On Fri, May 10, 2013 at 12:07:08AM +0800, Marek Lindner wrote:
> > > On Thursday, May 09, 2013 22:16:49 Antonio Quartulli wrote:
> > > > From: Antonio Quartulli <antonio@open-mesh.com>
> > > >
> > > > 
> > > >
> > > > In interface_rx() skb->data cannot be directly used to
> > > > access the Ethernet header because it point to the batman
> > > > one.
> > >
> > > 
> > >
> > > You don't believe that these calls (shortly before the code chunks you
> > > are  changing) are helpful ?
> > >
> > > 
> > >
> > > skb_pull_rcsum(skb, hdr_size);
> > > skb_reset_mac_header(skb);
> > 
> > You are right. Hence this is not fixing anything. It is just a
> > beautification and therefore we don't need it in maint.
> 
> Are you going to resend the patch with an updated commit message and subject 
> line ?


I'll take some time to find and beautify other similar spots.
Then I'll resend the updated patch for master.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]