* [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler
@ 2013-05-26 15:56 Linus Lüssing
2013-05-28 9:55 ` Marek Lindner
2013-06-09 4:05 ` Marek Lindner
0 siblings, 2 replies; 5+ messages in thread
From: Linus Lüssing @ 2013-05-26 15:56 UTC (permalink / raw)
To: b.a.t.m.a.n
We do not actually need to set any rx filters for the virtual batman
soft interface. However a dummy handler enables a user to set static
multicast listeners for instance.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
* Fixes issue #171
v2: added kernel doc
soft-interface.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/soft-interface.c b/soft-interface.c
index 2bad57f..54b3991 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -137,6 +137,18 @@ static int batadv_interface_change_mtu(struct net_device *dev, int new_mtu)
return 0;
}
+/**
+ * batadv_interface_set_rx_mode - set the rx mode of a device
+ * @dev: registered network device to modify
+ *
+ * We do not actually need to set any rx filters for the virtual batman
+ * soft interface. However a dummy handler enables a user to set static
+ * multicast listeners for instance.
+ */
+static void batadv_interface_set_rx_mode(struct net_device *dev)
+{
+}
+
static int batadv_interface_tx(struct sk_buff *skb,
struct net_device *soft_iface)
{
@@ -572,6 +584,7 @@ static const struct net_device_ops batadv_netdev_ops = {
.ndo_get_stats = batadv_interface_stats,
.ndo_set_mac_address = batadv_interface_set_mac_addr,
.ndo_change_mtu = batadv_interface_change_mtu,
+ .ndo_set_rx_mode = batadv_interface_set_rx_mode,
.ndo_start_xmit = batadv_interface_tx,
.ndo_validate_addr = eth_validate_addr,
.ndo_add_slave = batadv_softif_slave_add,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler
2013-05-26 15:56 [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler Linus Lüssing
@ 2013-05-28 9:55 ` Marek Lindner
2013-05-28 15:51 ` Linus Lüssing
2013-06-09 4:05 ` Marek Lindner
1 sibling, 1 reply; 5+ messages in thread
From: Marek Lindner @ 2013-05-28 9:55 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Sunday, May 26, 2013 23:56:07 Linus Lüssing wrote:
> @@ -572,6 +584,7 @@ static const struct net_device_ops batadv_netdev_ops =
> { .ndo_get_stats = batadv_interface_stats,
> .ndo_set_mac_address = batadv_interface_set_mac_addr,
> .ndo_change_mtu = batadv_interface_change_mtu,
> + .ndo_set_rx_mode = batadv_interface_set_rx_mode,
> .ndo_start_xmit = batadv_interface_tx,
> .ndo_validate_addr = eth_validate_addr,
> .ndo_add_slave = batadv_softif_slave_add,
Do we need compat code for this API call ?
Cheers,
Marek
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler
2013-05-28 9:55 ` Marek Lindner
@ 2013-05-28 15:51 ` Linus Lüssing
2013-06-07 21:16 ` Linus Lüssing
0 siblings, 1 reply; 5+ messages in thread
From: Linus Lüssing @ 2013-05-28 15:51 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Tue, May 28, 2013 at 05:55:44PM +0800, Marek Lindner wrote:
> On Sunday, May 26, 2013 23:56:07 Linus Lüssing wrote:
> > @@ -572,6 +584,7 @@ static const struct net_device_ops batadv_netdev_ops =
> > { .ndo_get_stats = batadv_interface_stats,
> > .ndo_set_mac_address = batadv_interface_set_mac_addr,
> > .ndo_change_mtu = batadv_interface_change_mtu,
> > + .ndo_set_rx_mode = batadv_interface_set_rx_mode,
> > .ndo_start_xmit = batadv_interface_tx,
> > .ndo_validate_addr = eth_validate_addr,
> > .ndo_add_slave = batadv_softif_slave_add,
>
> Do we need compat code for this API call ?
>
> Cheers,
> Marek
Yes it does, actually. A PATCHv3 will follow soonish. Thanks for
the hint!
Cheers, Linus
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler
2013-05-28 15:51 ` Linus Lüssing
@ 2013-06-07 21:16 ` Linus Lüssing
0 siblings, 0 replies; 5+ messages in thread
From: Linus Lüssing @ 2013-06-07 21:16 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Tue, May 28, 2013 at 05:51:14PM +0200, Linus Lüssing wrote:
> On Tue, May 28, 2013 at 05:55:44PM +0800, Marek Lindner wrote:
> > On Sunday, May 26, 2013 23:56:07 Linus Lüssing wrote:
> > > @@ -572,6 +584,7 @@ static const struct net_device_ops batadv_netdev_ops =
> > > { .ndo_get_stats = batadv_interface_stats,
> > > .ndo_set_mac_address = batadv_interface_set_mac_addr,
> > > .ndo_change_mtu = batadv_interface_change_mtu,
> > > + .ndo_set_rx_mode = batadv_interface_set_rx_mode,
> > > .ndo_start_xmit = batadv_interface_tx,
> > > .ndo_validate_addr = eth_validate_addr,
> > > .ndo_add_slave = batadv_softif_slave_add,
> >
> > Do we need compat code for this API call ?
> >
> > Cheers,
> > Marek
>
> Yes it does, actually. A PATCHv3 will follow soonish. Thanks for
> the hint!
Hm, I changed my mind, it actually shouldn't need any compat code.
At least compiling worked fine for me for 2.6.29 to 3.9 kernels.
There was a .ndo_set_multicast_list once with all these calls
being reassigned to .ndo_set_rx_mode and .ndo_set_multicast_list
being removed since 3.2 ("net: remove use of
ndo_set_multicast_list in drivers":afc4b13df143122f99a0eb10bfefb216c2806de0).
However .ndo_set_rx_mode has always been threre for
kernels >= 2.6.29, <= 3.9.
Cheers, Linus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler
2013-05-26 15:56 [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler Linus Lüssing
2013-05-28 9:55 ` Marek Lindner
@ 2013-06-09 4:05 ` Marek Lindner
1 sibling, 0 replies; 5+ messages in thread
From: Marek Lindner @ 2013-06-09 4:05 UTC (permalink / raw)
To: b.a.t.m.a.n
On Sunday, May 26, 2013 23:56:07 Linus Lüssing wrote:
> We do not actually need to set any rx filters for the virtual batman
> soft interface. However a dummy handler enables a user to set static
> multicast listeners for instance.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> * Fixes issue #171
>
> v2: added kernel doc
>
> soft-interface.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
Applied in revision 1cfaca7.
Thanks,
Marek
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-09 4:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-26 15:56 [B.A.T.M.A.N.] [PATCHv2] batman-adv: Add dummy soft-interface rx mode handler Linus Lüssing
2013-05-28 9:55 ` Marek Lindner
2013-05-28 15:51 ` Linus Lüssing
2013-06-07 21:16 ` Linus Lüssing
2013-06-09 4:05 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox