Re: [B.A.T.M.A.N.] [PATCHv2 3/3] batman-adv: Modified forwarding behaviour for multicast packets

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On Wed, May 29, 2013 at 12:39:33AM +0800, Marek Lindner wrote:
> On Tuesday, May 28, 2013 23:40:54 Simon Wunderlich wrote:
> > You can safe an indendation below if you return -1 immediately here
> > if the statement above is false. Also multiple statements might be better
> > for readability and later changes, e.g.
> > 
> > if (!atomic_read(&bat_priv->mcast_group_awareness))
> >         return 1;
> > 
> > if (atomic_read(&bat_priv->mcast.num_non_aware))
> >         return 1;
> > 
> > if (ntohs(ethhdr->h_proto) != ETH_P_IPV6)
> >         return 1;
> 
> A quick hint from my end: The kernel maintainer don't like code that returns 
> "random" values like 1/0/-1. Either use bool or meaningful defines instead of 
> raw numbers.

Very good suggestion.
I think you can define an enum for this. It will make the code much easier to
understand.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]