Re: [B.A.T.M.A.N.] [RFC 00/10] Improving the routing protocol abstraction

Martin Hundebøll
2013-05-29T06:20:15Z

Hi Antonio,

Great work. We are looking forward to the next generation of Batman
(shouldn't that be Robin?) :)

On 2013-05-29 00:20, Antonio Quartulli wrote:
> Antonio Quartulli (10):
> batman-adv: make struct batadv_neigh_node algorithm agnostic
> batman-adv: make struct batadv_orig_node algorithm agnostic
> batman-adv: add bat_orig_print function API
> batman-adv: add bat_metric_get API function
> batman-adv: add bat_metric_is_similar API function
> batman-adv: add bat_metric_compare API function
> batman-adv: adapt bonding to use the new API functions
> batman-adv: adapt the gateway feature to use the new API functions
> batman-adv: adapt the neighbor purging routine to use the new API
> functions
> batman-adv: provide orig_node routing API

I see that in nc.c you changed the uses of neigh_node->tq_avg to the new
private algo-specific struct (neigh_node->bat_iv.tq_avg), but there is
no patch to make nc.c use the new API (bat_algo_ops.bat_metric_get() )...

Is this because you were in doubt wether NC will be usable with bat_v or
just because you did "make && git-push" ? :)

I am sure NC will need some work in order to support bat_v, and I will
try to catch up soon...

--
Kind Regards
Martin Hundebøll
Frederiks Allé 99, 1.th
8000 Aarhus C
Denmark

+45 61 65 54 61
martin@hundeboll.net