From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv4 08/13] batman-adv: treat bat0 like yet another VLAN
Date: Sun, 9 Jun 2013 16:20:48 +0200 [thread overview]
Message-ID: <20130609142048.GB3347@ritirata.org> (raw)
In-Reply-To: <201306092213.59813.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
On Sun, Jun 09, 2013 at 10:13:59PM +0800, Marek Lindner wrote:
> On Tuesday, June 04, 2013 18:11:46 Antonio Quartulli wrote:
> > To make the code simpler and easier to extend, treat the
> > normal LAN (bat0) like any other VLAN having vid 0
> > (untagged).
> >
> > This change makes things simpler since bat0 is not a
> > particular case anymore but it is treated like any other
> > VLAN.
>
> What makes you think "vid 0" is not a valid vlan tag ? If this patch is
> applied how can I create a VLAN 0 on top of batX ?
The commit message talks about the value of the vid variable (used to keep the
value of the VID, of course) and as introduced in a previous patch, if the
HAS_TAG bit is not set, then we don't consider the this variable to represent a
real VID.
VLAN 0 on top of batX will generate vid = (HAS_TAG | 0), while in this case I am
talking about vid = 0.
This is implicit in the vid variables semantic previously introduced and this
is what I meant with that "untagged" at the end of the sentence.
Maybe we should substitute "having vid 0" with "having vid with no HAS_TAG bit
set" ?
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-09 14:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 10:11 [B.A.T.M.A.N.] [PATCHv4 00/13] make the Translation Table component VLAN-aware Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 01/13] batman-adv: add the VLAN ID attribute to the TT entry Antonio Quartulli
2013-06-09 13:50 ` Marek Lindner
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 02/13] batman-adv: use vid when computing local and global TT CRC Antonio Quartulli
2013-06-09 13:55 ` Marek Lindner
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 03/13] batman-adv: print the VID together with the TT entries Antonio Quartulli
2013-06-09 13:58 ` Marek Lindner
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 04/13] batman-adv: make the GW module correctly talk to the new VLAN-TT Antonio Quartulli
2013-06-09 14:02 ` Marek Lindner
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 05/13] batman-adv: make the Distributed ARP Table vlan aware Antonio Quartulli
2013-06-09 14:11 ` Marek Lindner
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 06/13] batman-adv: add per VLAN interface attribute framework Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 07/13] batman-adv: initialise sysfs folder in softif_create() Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 08/13] batman-adv: treat bat0 like yet another VLAN Antonio Quartulli
2013-06-09 14:13 ` Marek Lindner
2013-06-09 14:20 ` Antonio Quartulli [this message]
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 09/13] batman-adv: add sysfs framework for VLAN Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 10/13] batman-adv: make the AP isolation attribute VLAN specific Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 11/13] batman-adv: make the backbone gw check " Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 12/13] batman-adv: make the TT global purge routine " Antonio Quartulli
2013-06-04 10:11 ` [B.A.T.M.A.N.] [PATCHv4 13/13] batman-adv: make the TT CRC logic " Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609142048.GB3347@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox