public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] Basic Multicast Optimizations
Date: Wed, 12 Jun 2013 12:14:11 +0200	[thread overview]
Message-ID: <20130612101411.GA13323@pandem0nium> (raw)
In-Reply-To: <1370848318-18755-1-git-send-email-linus.luessing@web.de>

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Hello Linus,

I gave it a try - but there seems something off. What I did is:
 * apply your patches on 3b38a80 - multicast was enabled by default
 * start 2 VMs directly connected
 * ping6 -I bat0 ff02::1

I only got a reply locally, but not from the peer. When I disabled
multicast, I got two replies from the local host and the peer.

As far as I have tracked the problem down, it appears that
batadv_mcast_forw_mode() returns 1 correctly, but the packet is dropped
later in the process - I would guess that this happens in
batadv_send_generic_unicast_skb() where we try to select the gateway
when the destination mac is multicast instead of looking it up in the
tt table. But I leave the details to you. :)

The rest looks good, but I'll review more deeply again when it's
actually working. It does compile without problems now.

Cheers,
	Simon

On Mon, Jun 10, 2013 at 09:11:55AM +0200, Linus Lüssing wrote:
> This is the fourth revision of the basic multicast optimization patches.
> 
> It adds a missing enum keyword to the return type of a mcast_forw_mode().
> 
> Cheers, Linus

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2013-06-12 10:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  7:11 [B.A.T.M.A.N.] Basic Multicast Optimizations Linus Lüssing
2013-06-10  7:11 ` [B.A.T.M.A.N.] [PATCHv4 1/3] batman-adv: Multicast Listener Announcements via Translation Table Linus Lüssing
2013-06-10  7:11 ` [B.A.T.M.A.N.] [PATCHv4 2/3] batman-adv: Announce new capability via multicast TVLV Linus Lüssing
2013-06-10  7:11 ` [B.A.T.M.A.N.] [PATCHv4 3/3] batman-adv: Modified forwarding behaviour for multicast packets Linus Lüssing
2013-06-12 10:14 ` Simon Wunderlich [this message]
2013-06-12 12:27   ` [B.A.T.M.A.N.] Basic Multicast Optimizations Linus Lüssing
2013-06-12 12:44     ` Simon Wunderlich
2013-06-12 20:33       ` Linus Lüssing
  -- strict thread matches above, loose matches on Subject: below --
2014-01-27  9:48 Linus Lüssing
2013-11-14  6:26 Linus Lüssing
2013-10-26 19:16 Linus Lüssing
2013-08-15 19:21 Linus Lüssing
2013-08-19 20:12 ` Simon Wunderlich
2013-08-13  8:23 Linus Lüssing
2013-08-15 13:56 ` Simon Wunderlich
2013-08-15 18:25   ` Linus Lüssing
2013-07-03 22:03 Linus Lüssing
2013-07-04  5:06 ` Linus Lüssing
2013-06-14 17:50 Linus Lüssing
2013-06-16 14:08 ` Simon Wunderlich
2013-06-14  9:02 Linus Lüssing
2013-06-10  6:28 Linus Lüssing
2013-06-10  7:06 ` Linus Lüssing
2013-05-24  8:02 Linus Lüssing
2013-05-24  9:00 ` Linus Lüssing
2013-05-24  9:06   ` Antonio Quartulli
2013-05-24  9:33 ` Marek Lindner
2013-05-11 17:23 Linus Lüssing
2013-05-16 11:51 ` Simon Wunderlich
2013-05-16 17:42   ` Linus Lüssing
2013-05-16 18:31     ` Simon Wunderlich
2013-05-17  1:38       ` Linus Lüssing
2013-05-17 10:24         ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612101411.GA13323@pandem0nium \
    --to=simon.wunderlich@s2003.tu-chemnitz.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox