Re: [B.A.T.M.A.N.] [PATCHv6 1/3] batman-adv: Multicast Listener Announcements via Translation Table

Linus Lüssing
2013-06-26T09:38:00Z

On Tue, Jun 25, 2013 at 03:03:16PM +0200, Antonio Quartulli wrote:
> > > All struct defines should go into types.h or packet.h if they are sent over
> > > the wire.

I just noticed that I had misread this sentence as: "All struct
defines which are sent over the wire go into types.h or packet.h"

> >
> > This struct isn't sent over the wire, it's just for local book
> > keeping. I was thinking about naming it 'struct batadv_mcast_hw_addr'
> > but didn't do that because it is so generic and thought maybe
> > because of that it might be reusable in the future.
> >
> > Hm, maybe it's better to rename it to 'struct
> > batadv_mcast_hw_addr' anyways and leave it in that place to avoid
> > bloating types.h/packet.h with "unimportant" structs and defines?
>
> I think this struct should go into type.h too. Many structs in there are used by
> a single component only, but it is better to keep them into the same file.
> And yes, renaming to batadv_mcast_hw_addr is probably better (given that it is
> used by the mcast component only).

And now this makes sense :). I'm going to move it into types.h (and
will keep the name as batadv_hw_addr).

>
> Cheers,
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara