From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [RFCv2 10/10] batman-adv: adapt the TT component to use the new API functions
Date: Sat, 3 Aug 2013 23:17:57 +0200 [thread overview]
Message-ID: <20130803211755.GF12891@pandem0nium> (raw)
In-Reply-To: <1375303667-3018-11-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Wed, Jul 31, 2013 at 10:47:47PM +0200, Antonio Quartulli wrote:
> +
> + if (metric <= best_metric)
> + continue;
> +
> + best_entry = orig_entry;
> + best_metric = metric;
Why don't you use the bat_metric_compare() function here?
BTW, do we need bat_metric_compare() anyway? I think both TQ and the metric in BATMAN V
can work with integer comparison, so as long as we don't add some other "special" metrics
we might not need this bat_metric_compare() at all?
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-08-03 21:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 20:47 [B.A.T.M.A.N.] [RFCv2 00/10] Improving the routing protocol abstraction Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 01/10] batman-adv: make struct batadv_neigh_node algorithm agnostic Antonio Quartulli
2013-08-03 20:57 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 02/10] batman-adv: make struct batadv_orig_node " Antonio Quartulli
2013-08-03 21:05 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 03/10] batman-adv: add bat_orig_print function API Antonio Quartulli
2013-08-03 21:07 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 04/10] batman-adv: add bat_metric_get API function Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 05/10] batman-adv: add bat_metric_is_equiv_or_better " Antonio Quartulli
2013-08-03 21:10 ` Simon Wunderlich
2013-08-10 16:24 ` Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 06/10] batman-adv: add bat_metric_compare " Antonio Quartulli
2013-08-03 21:10 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 07/10] batman-adv: adapt bonding to use the new API functions Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 08/10] batman-adv: adapt the neighbor purging routine " Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 09/10] batman-adv: provide orig_node routing API Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 10/10] batman-adv: adapt the TT component to use the new API functions Antonio Quartulli
2013-08-03 21:17 ` Simon Wunderlich [this message]
2013-08-03 21:19 ` [B.A.T.M.A.N.] [RFCv2 00/10] Improving the routing protocol abstraction Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130803211755.GF12891@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox