Re: [B.A.T.M.A.N.] [PATCHv9 1/2] batman-adv: lock around TT operations to avoid sending inconsistent data

[Marek Lindner <lindner_marek@yahoo.de>]

On Wednesday, July 31, 2013 04:16:24 Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
> 
> A TT response may be prepared and sent while the local or
> global translation table is getting updated.
> 
> The worst case is when one of the tables is accessed after
> its content has been recently updated but the metadata
> (TTVN/CRC) has not yet. In this case the reader will get a
> table content which does not match the TTVN/CRC.
> This will lead to an inconsistent state and so to a TT
> recovery.
> 
> To avoid entering this situation, put a lock around those TT
> operations recomputing the metadata and around the TT
> Response creation (the latter is the only reader that
> accesses the metadata together with the table).
> 
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
>  main.c              |  1 +
>  originator.c        |  1 +
>  translation-table.c | 23 +++++++++++++++++++----
>  types.h             | 13 +++++++++++++
>  4 files changed, 34 insertions(+), 4 deletions(-)

Applied in revision 1583626.

Thanks,
Marek