From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [RFCv2 05/10] batman-adv: add bat_metric_is_equiv_or_better API function
Date: Sat, 10 Aug 2013 18:24:14 +0200 [thread overview]
Message-ID: <20130810162414.GE849@ritirata.org> (raw)
In-Reply-To: <20130803211005.GD12891@pandem0nium>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
On Sat, Aug 03, 2013 at 11:10:07PM +0200, Simon Wunderlich wrote:
> > +static bool batadv_iv_ogm_metric_is_eob(uint32_t metric, uint32_t new_metric)
> > +{
> > + return (metric - new_metric < BATADV_TQ_SIMILARITY_THRESHOLD);
> > +}
> > +
>
> Since it's static anyway, maybe call this function batadv_iv_ogm_metric_is_equiv_or_better instead? eob
if I use batadv_iv_ogm_metric_is_equiv_or_better than I have problems wit hthe
assignment of the ops member later...line toooo long :) This is why I chose that
name.
> looks so ... random. :) Also, maybe use BATADV_IV_TQ_SIMILARITY_THRESHOLD? Although TQ somehow implies
> BATADV_IV ...
I don't think it is correct. Metric is separated from the algorithm and and this
define belongs to the metric. In the future we may have B.A.T.M.A.N. X which
wants to use the TQ again..at that point it should (re-)use all the constants we
already have.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-10 16:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 20:47 [B.A.T.M.A.N.] [RFCv2 00/10] Improving the routing protocol abstraction Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 01/10] batman-adv: make struct batadv_neigh_node algorithm agnostic Antonio Quartulli
2013-08-03 20:57 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 02/10] batman-adv: make struct batadv_orig_node " Antonio Quartulli
2013-08-03 21:05 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 03/10] batman-adv: add bat_orig_print function API Antonio Quartulli
2013-08-03 21:07 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 04/10] batman-adv: add bat_metric_get API function Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 05/10] batman-adv: add bat_metric_is_equiv_or_better " Antonio Quartulli
2013-08-03 21:10 ` Simon Wunderlich
2013-08-10 16:24 ` Antonio Quartulli [this message]
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 06/10] batman-adv: add bat_metric_compare " Antonio Quartulli
2013-08-03 21:10 ` Simon Wunderlich
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 07/10] batman-adv: adapt bonding to use the new API functions Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 08/10] batman-adv: adapt the neighbor purging routine " Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 09/10] batman-adv: provide orig_node routing API Antonio Quartulli
2013-07-31 20:47 ` [B.A.T.M.A.N.] [RFCv2 10/10] batman-adv: adapt the TT component to use the new API functions Antonio Quartulli
2013-08-03 21:17 ` Simon Wunderlich
2013-08-03 21:19 ` [B.A.T.M.A.N.] [RFCv2 00/10] Improving the routing protocol abstraction Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810162414.GE849@ritirata.org \
--to=ordex@autistici.org \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox