From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: check if a softif_vlan already exists
Date: Tue, 20 Aug 2013 08:39:06 +0200 [thread overview]
Message-ID: <20130820063906.GA2963@ritirata.org> (raw)
In-Reply-To: <20130819202028.GB18020@pandem0nium>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Mon, Aug 19, 2013 at 10:20:28PM +0200, Simon Wunderlich wrote:
> Hey Antonio,
>
> Thanks, that solves the problem on my ancient kernel! :)
>
> I don't see a problem with -EEXIST (at least there is no error
> whatsoever), so I think we can leave it at that.
>
> Tested-by: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
>
> Just one thing ...
>
> On Thu, Aug 15, 2013 at 11:05:55PM +0200, Antonio Quartulli wrote:
> > From: Antonio Quartulli <antonio@open-mesh.com>
> >
> > Before creating a new softif_vlan it is better to check if
> > that does already exist.
> > If so batman-adv should refuse to create a new structure
> > otherwise this would lead to an inconsistent state.
> >
> > Normally this is not a problem because the operating system
> > will prevent from creating the same vlan twice, but some
> > ancient kernels exhibited an improper behaviour that led to
> > a bug.
>
> You might want to skip that when sending upstream? They might not
> care about older kernels. Duno. :)
This patch is only for us, because it is going to be squashed with a previous
one before going to David. So I'd leave the commit message as it is.
Cheers,
>
> Thanks!
> Simon
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-20 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 13:13 [B.A.T.M.A.N.] Regression in VLAN sysfs patches Simon Wunderlich
2013-08-15 17:45 ` [B.A.T.M.A.N.] [PATCH] batman-adv: print some info for vlan debugging Antonio Quartulli
2013-08-15 19:32 ` [B.A.T.M.A.N.] [PATCH] batman-adv: check if a softif_vlan already exists Antonio Quartulli
2013-08-15 21:05 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2013-08-19 20:20 ` Simon Wunderlich
2013-08-20 6:39 ` Antonio Quartulli [this message]
2013-08-20 8:13 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820063906.GA2963@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox