From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: print the VID in the dat_cache output
Date: Thu, 22 Aug 2013 10:45:29 +0200 [thread overview]
Message-ID: <20130822084529.GE2963@ritirata.org> (raw)
In-Reply-To: <201308221552.36925.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Thu, Aug 22, 2013 at 03:52:36PM +0800, Marek Lindner wrote:
> On Thursday, August 22, 2013 15:21:11 Antonio Quartulli wrote:
> > @@ -761,8 +761,8 @@ int batadv_dat_cache_seq_print_text(struct seq_file
> > *seq, void *offset) goto out;
> >
> > seq_printf(seq, "Distributed ARP Table (%s):\n", net_dev->name);
> > - seq_printf(seq, " %-7s %-13s %5s\n", "IPv4",
> > "MAC", - "last-seen");
> > + seq_printf(seq, " %-7s %-9s %4s %11s\n", "IPv4",
> > + "MAC", "VID", "last-seen");
>
> Why are you shortening the MAC address length while you try to add the vid ?
This is only to arrange the header line. If you test the code, you will see it
looks good this way :) I also added some more space at the last-seen text to
space it correctly.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-22 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 7:21 [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: print the VID in the dat_cache output Antonio Quartulli
2013-08-22 7:21 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: fix ARP header parsing in DAT Antonio Quartulli
2013-08-25 6:56 ` Marek Lindner
2013-08-22 7:21 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: tag locally generated ARP reply if needed Antonio Quartulli
2013-08-25 7:06 ` Marek Lindner
2013-08-22 7:52 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: print the VID in the dat_cache output Marek Lindner
2013-08-22 8:45 ` Antonio Quartulli [this message]
2013-08-25 6:53 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822084529.GE2963@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox