From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: limit local translation table max size
Date: Sun, 1 Sep 2013 10:05:43 +0200 [thread overview]
Message-ID: <20130901080543.GA1871@ritirata.org> (raw)
In-Reply-To: <201309011248.44874.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
On Sun, Sep 01, 2013 at 12:48:44PM +0800, Marek Lindner wrote:
> On Sunday, September 01, 2013 02:38:29 Antonio Quartulli wrote:
> > > @@ -717,12 +762,6 @@ static void batadv_tt_tvlv_container_update(struct
> > > batadv_priv *bat_priv)
> > >
> > > tt_diff_entries_num = atomic_read(&bat_priv->tt.local_changes);
> > > tt_diff_len = batadv_tt_len(tt_diff_entries_num);
> > >
> > > - /* if we have too many changes for one packet don't send any
> > > - * and wait for the tt table request which will be fragmented
> > > - */
> > > - if (tt_diff_len > bat_priv->soft_iface->mtu)
> > > - tt_diff_len = 0;
> > > -
> >
> > Why are you removing this? We are not going to fragment OGMs and in this
> > function we are preparing the TVLV to send within one of those.
>
> Upon reading this function a realized this "tt_diff_len = 0" mechanism is
> buggy. For instance, the changes_list list is not purged but keeps growing
> until it magically fits the ogm diff again. Or checking bat_priv->soft_iface-
> >mtu isn't terribly accurate either. The more I looked the more my head
> started to spin. Suddenly, I was convinced we don't need the check anymore
> because we have the fragmentation but you are right - it won't help here. I'll
> add the check again but be aware that it is broken.
Right, there is a bug. We should purge the list in any case, even if tt_diff_len
is 0.
Yes, checking tt_diff_len against bat_priv->soft_iface->mtu is probably not
correct..shall we check it against the mtu of the primary interface?
Anyway, this is outside the scope of this patch.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-01 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 15:33 [B.A.T.M.A.N.] [PATCH] batman-adv: limit local translation table max size Marek Lindner
2013-08-31 18:38 ` Antonio Quartulli
2013-09-01 4:48 ` Marek Lindner
2013-09-01 8:05 ` Antonio Quartulli [this message]
2013-09-01 16:49 ` Marek Lindner
2013-09-01 17:04 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130901080543.GA1871@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox