From: Antonio Quartulli <antonio@meshcoding.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <lindner_marek@yahoo.de>,
davem@davemloft.net, Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/16] batman-adv: add bat_orig_print API function
Date: Wed, 23 Oct 2013 19:18:10 +0200 [thread overview]
Message-ID: <20131023171810.GB2651@neomailbox.net> (raw)
In-Reply-To: <1382547630.22433.23.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 2648 bytes --]
On Wed, Oct 23, 2013 at 10:00:30AM -0700, Joe Perches wrote:
> On Wed, 2013-10-23 at 18:04 +0200, Antonio Quartulli wrote:
> > Each routing protocol has its own metric and private
> > variables, therefore it is useful to introduce a new API
> > for originator information printing.
> >
> > This API needs to be implemented by each protocol in order
> > to provide its specific originator table output.
> []
> > +static void batadv_iv_ogm_orig_print(struct batadv_priv *bat_priv,
> > + struct seq_file *seq)
> []
> > + seq_printf(seq, " %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",
> > + "Originator", "last-seen", "#", BATADV_TQ_MAX_VALUE,
> > + "Nexthop", "outgoingIF", "Potential nexthops");
>
> This header printf really doesn't add much with the formatting sizes.
> It's pretty obscure why some of these are sized and others not sized.
> For instance: %-15s doesn't refer to a mac address size.
> Perhaps it'd be better to just emit the fixed string just using
> BATADV_TO_MAX_VALUE. It'd also be easier to find via grep.
This string is printed out of a debugfs file and follows a format that we have
been using for long time (this patch is just moving this code from one point to
another).
I didn't get what you mean with BATADV_TO_MAX_VALUE (maybe you meant
BATADV_TQ_MAX_VALUE? but even in this case I don't get it).
The sized parameters in the format string are such that this header is correctly
aligned with the entries of the table that follow.
Moreover we tried to keep this table human readable as much as possible.
Here you have an example of what we get (this output is not printed with exactly
that format string because it belongs to an older batman-adv version)
[B.A.T.M.A.N. adv 2013.3.0, MainIF/MAC: mesh0/xx:xx:xx:xx:xx:xx (bat0)]
Originator last-seen (#/255) Nexthop [outgoingIF]: Potential nexthops ...
yyyy 4.720s (247) yyyy [ mesh0]: aaaaa (221) bbbbbb (200)
aaaaa 4.270s (237) ddddd [ mesh0]: aaaa (195) vvvvvv (215)
bbbbbb 4.480s (248) cccccc [ mesh0]: bbbb (213) cccccc (200)
ccccc 0.480s (255) bbbbb [ mesh0]: cccc (217) dddddd (190)
dddddd 1.050s (223) dddddd [ mesh0]: dddddd (191) eeee (203)
If the width of your terminal is adequate you get a nice table which is rather
helpful for debugging purposes.
Regards,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-23 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 16:04 [B.A.T.M.A.N.] pull request: batman-adv 2013-10-23 Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 01/16] batman-adv: make struct batadv_neigh_node algorithm agnostic Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 02/16] batman-adv: make struct batadv_orig_node " Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 03/16] batman-adv: add bat_orig_print API function Antonio Quartulli
2013-10-23 17:00 ` Joe Perches
2013-10-23 17:18 ` Antonio Quartulli [this message]
2013-10-23 17:27 ` Joe Perches
2013-10-23 17:37 ` Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 04/16] batman-adv: add bat_neigh_cmp " Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 05/16] batman-adv: add bat_neigh_is_equiv_or_better " Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 06/16] batman-adv: adapt bonding to use the new API functions Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 07/16] batman-adv: adapt the neighbor purging routine " Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 08/16] batman-adv: provide orig_node routing API Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 09/16] batman-adv: adapt the TT component to use the new API functions Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 10/16] batman-adv: limit local translation table max size Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 11/16] batman-adv: send GW_DEL event in case of soft-iface destruction Antonio Quartulli
2013-10-23 16:04 ` [B.A.T.M.A.N.] [PATCH 12/16] batman-adv: invoke dev_get_by_index() outside of is_wifi_iface() Antonio Quartulli
2013-10-23 16:05 ` [B.A.T.M.A.N.] [PATCH 13/16] batman-adv: improve the TT component to support runtime flag changes Antonio Quartulli
2013-10-23 16:05 ` [B.A.T.M.A.N.] [PATCH 14/16] batman-adv: include the sync-flags when compute the global/local table CRC Antonio Quartulli
2013-10-23 16:05 ` [B.A.T.M.A.N.] [PATCH 15/16] batman-adv: Start new development cycle Antonio Quartulli
2013-10-23 16:05 ` [B.A.T.M.A.N.] [PATCH 16/16] batman-adv: generalize batman-adv icmp packet handling Antonio Quartulli
2013-10-23 21:13 ` [B.A.T.M.A.N.] pull request: batman-adv 2013-10-23 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023171810.GB2651@neomailbox.net \
--to=antonio@meshcoding.com \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox