From: "Linus Lüssing" <linus.luessing@web.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: silence smatch errors in multicast compat code
Date: Sun, 16 Feb 2014 12:31:26 +0100 [thread overview]
Message-ID: <20140216113126.GG28274@Linus-Debian> (raw)
In-Reply-To: <1384187589-23259-1-git-send-email-sw@simonwunderlich.de>
On Mon, Nov 11, 2013 at 05:33:09PM +0100, Simon Wunderlich wrote:
> diff --git a/compat.h b/compat.h
> index 186547b..a99c9d5 100644
> --- a/compat.h
> +++ b/compat.h
> @@ -160,14 +160,12 @@ static inline int batadv_param_set_copystring(const char *val,
> #define NET_ADDR_RANDOM 0
>
> #define netdev_master_upper_dev_get_rcu(dev) \
> - upper; \
> - rcu_read_unlock(); \
> + NULL; \
> if (dev->br_port ? 1 : 0) { \
> + rcu_read_unlock(); \
> dev_hold(dev); \
> return dev; \
> } \
> -\
> - return NULL\
>
This approach unfortunately doesn't work and leads to crashes
because we assign NULL to upper and therefore dev, too, leading to
a null pointer exception when trying to access dev->br-port.
As the smatch warning is just a compat warning not leading to any
issues despite that, could we simply silence the build system to
ignore this instead?
prev parent reply other threads:[~2014-02-16 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 16:33 [B.A.T.M.A.N.] [PATCH] batman-adv: silence smatch errors in multicast compat code Simon Wunderlich
2014-02-16 11:31 ` Linus Lüssing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140216113126.GG28274@Linus-Debian \
--to=linus.luessing@web.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox