Re: [B.A.T.M.A.N.] [PATCHv2 next 03/11] batman-adv: fix multicast kerneldoc

["Linus Lüssing" <linus.luessing@web.de>]

Hi Antonio,

Two things are confusing me, firstly:

On Wed, Mar 19, 2014 at 09:08:44AM +0100, Antonio Quartulli wrote:
> The kerneldoc should always use the third person singular in
> the long function description.
> Moreover it should always try use up to 80 chars per line.

vs.

On Sun, May 12, 2013 at 12:55:25AM +0200, Antonio Quartulli wrote:
> For some reason we agreed on not using the third person while describing the
> function. For consistency I'd suggest you to do the same your kernel doc.
>

Secondly:

Why do you only change it in multicast.{c,h}, why not changing
things everywhere? For instance translation-table.c sometimes uses
"Returns", sometimes "Return".

Or functions in translation-table.c using first person in their
description:
* batadv_tt_prepare_tvlv_global_data()
* batadv_tt_prepare_tvlv_local_data()
* batadv_tt_global_add()
* batadv_tt_global_del_orig_entry()
* batadv_tt_global_del_orig_node()
* batadv_send_roam_adv()
* batadv_tt_local_resize_to_mtu()

While these using the third one:
* batadv_transtable_best_orig()
* batadv_tt_global_print_entry()
* batadv_tt_global_crc()
* batadv_tt_check_roam_count()


Cheers, Linus