* [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences
@ 2014-04-23 19:41 Marek Lindner
2014-04-24 12:00 ` Antonio Quartulli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Lindner @ 2014-04-23 19:41 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
Changes from v1:
- add next branch indication
multicast.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/multicast.c b/multicast.c
index 8c7ca81..96b66fd 100644
--- a/multicast.c
+++ b/multicast.c
@@ -415,7 +415,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv)
hlist_for_each_entry_rcu(tmp_orig_node,
&bat_priv->mcast.want_all_ipv4_list,
mcast_want_all_ipv4_node) {
- if (!atomic_inc_not_zero(&orig_node->refcount))
+ if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
continue;
orig_node = tmp_orig_node;
@@ -442,7 +442,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv)
hlist_for_each_entry_rcu(tmp_orig_node,
&bat_priv->mcast.want_all_ipv6_list,
mcast_want_all_ipv6_node) {
- if (!atomic_inc_not_zero(&orig_node->refcount))
+ if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
continue;
orig_node = tmp_orig_node;
@@ -493,7 +493,7 @@ batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv)
hlist_for_each_entry_rcu(tmp_orig_node,
&bat_priv->mcast.want_all_unsnoopables_list,
mcast_want_all_unsnoopables_node) {
- if (!atomic_inc_not_zero(&orig_node->refcount))
+ if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
continue;
orig_node = tmp_orig_node;
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences
2014-04-23 19:41 [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences Marek Lindner
@ 2014-04-24 12:00 ` Antonio Quartulli
2014-05-02 4:52 ` Linus Lüssing
2014-05-02 5:11 ` Marek Lindner
2 siblings, 0 replies; 4+ messages in thread
From: Antonio Quartulli @ 2014-04-24 12:00 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking; +Cc: Marek Lindner
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
On 23/04/14 21:41, Marek Lindner wrote:
> Reported-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
I sent the ACK for v1, but it is valid for this version as well.
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences
2014-04-23 19:41 [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences Marek Lindner
2014-04-24 12:00 ` Antonio Quartulli
@ 2014-05-02 4:52 ` Linus Lüssing
2014-05-02 5:11 ` Marek Lindner
2 siblings, 0 replies; 4+ messages in thread
From: Linus Lüssing @ 2014-05-02 4:52 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
On Thu, Apr 24, 2014 at 03:41:26AM +0800, Marek Lindner wrote:
> Reported-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> ---
>
> Changes from v1:
> - add next branch indication
>
> multicast.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/multicast.c b/multicast.c
> index 8c7ca81..96b66fd 100644
> --- a/multicast.c
> +++ b/multicast.c
> @@ -415,7 +415,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_ipv4_list,
> mcast_want_all_ipv4_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> @@ -442,7 +442,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_ipv6_list,
> mcast_want_all_ipv6_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> @@ -493,7 +493,7 @@ batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_unsnoopables_list,
> mcast_want_all_unsnoopables_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> --
> 2.0.0.rc0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences
2014-04-23 19:41 [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences Marek Lindner
2014-04-24 12:00 ` Antonio Quartulli
2014-05-02 4:52 ` Linus Lüssing
@ 2014-05-02 5:11 ` Marek Lindner
2 siblings, 0 replies; 4+ messages in thread
From: Marek Lindner @ 2014-05-02 5:11 UTC (permalink / raw)
To: b.a.t.m.a.n, Sven Eckelmann
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Thursday 24 April 2014 03:41:26 Marek Lindner wrote:
> Reported-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> ---
>
> Changes from v1:
> - add next branch indication
>
> multicast.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied in revision be45ab5.
Regards,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-02 5:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 19:41 [B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences Marek Lindner
2014-04-24 12:00 ` Antonio Quartulli
2014-05-02 4:52 ` Linus Lüssing
2014-05-02 5:11 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox