From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 01/10] batadv-vis: Avoid memory leak after failed realloc
Date: Tue, 27 May 2014 16:08:03 +0200 [thread overview]
Message-ID: <201405271608.03313.sw@simonwunderlich.de> (raw)
In-Reply-To: <1400931855-7961-1-git-send-email-sven@narfation.org>
> realloc doesn't free the original buffer when the reallocation failed. An
> abort of read_file without free'ing the buffer would leak it.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
The whole series has been applied with two minor fixes:
* fixed a typo: alfred-gpsd: Fix altitute verification check -> altitude
* fixed sign of length calculation in alfred: Fix length check for push_data
Thanks!
Simon
prev parent reply other threads:[~2014-05-27 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 11:44 [B.A.T.M.A.N.] [PATCH 01/10] batadv-vis: Avoid memory leak after failed realloc Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 02/10] alfred: Force null termination of string after strncpy Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 03/10] batadv-vis: Avoid memory leak when tl parsing failed Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 04/10] alfred: Use pre-allocated object for global variables Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 05/10] batadv-vis: Avoid invalid access in orig_list Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 06/10] alfred-gpsd: Fix altitute verification check Sven Eckelmann
2014-05-24 14:45 ` Andrew Lunn
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 07/10] alfred: Use strncpy instead of strcpy for string copy Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 08/10] alfred: Free hash iterator when breaking out of loop Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 09/10] alfred: Handle fcntl error return codes Sven Eckelmann
2014-05-24 11:44 ` [B.A.T.M.A.N.] [PATCH 10/10] alfred: Fix length check for push_data Sven Eckelmann
2014-05-27 14:08 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201405271608.03313.sw@simonwunderlich.de \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox