From: "Linus Lüssing" <linus.luessing@web.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix counter for multicast supporting nodes
Date: Sat, 11 Oct 2014 12:32:22 +0200 [thread overview]
Message-ID: <20141011103222.GD31424@odroid> (raw)
In-Reply-To: <1412975746-6856-1-git-send-email-linus.luessing@web.de>
On Fri, Oct 10, 2014 at 11:15:46PM +0200, Linus Lüssing wrote:
> A miscounting of nodes having multicast optimizations enabled can lead
> to multicast packet loss in the following scenario:
>
> If the first OGM a node receives from another one has no multicast
> optimizations support (no multicast tvlv) then we are missing to
> increase the counter. This potentially leads to the wrong assumption
> that we could safely use multicast optimizations.
>
> Fixings this by increasing the counter if the initial OGM has the
> multicast TVLV unset, too.
>
> Introduced by 77ec494490d60d89b42cd01d5dbf8dee04503623
> ("batman-adv: Announce new capability via multicast TVLV")
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> multicast.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reported-by: Tobias Hachmer <tobias@hachmer.de>
prev parent reply other threads:[~2014-10-11 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 21:15 [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix counter for multicast supporting nodes Linus Lüssing
2014-10-11 10:32 ` Linus Lüssing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011103222.GD31424@odroid \
--to=linus.luessing@web.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox