From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv9 4/4] batman-adv: Forward IGMP/MLD reports to selected querier (only)
Date: Wed, 26 Nov 2014 17:37:43 +0100 [thread overview]
Message-ID: <20141126163743.GB3837@odroid> (raw)
In-Reply-To: <5961070.CapjBEeMcY@prime>
On Mon, Nov 24, 2014 at 03:56:06PM +0100, Simon Wunderlich wrote:
> As a general note: This patch adds ~400 lines for mainly processing IGMP/MLD
> stuff, right? Shouldn't this kind of IP/IGMP/MLD report detection and
> memorizing the Querier rather go in the bridge code instead of batman-adv, or
> is there any functionality there already? IMHO the preferred position would be
> the bridge code since its more general/used by more people on one hand, and
> does not bloat batman-adv on the other hand. :)
>
> Could you give us some comments regarding who should do IGMP/MLD processing in
> the kernel so we are prepared for these kind of upstream questions?
Currently, with this patch, the decisions about where to forward IGMP/MLD
reports in batman-adv is done on the multicast listener / report sender side.
With this approach, as seen in the picture, even a node without
the bridge (the blue node 'L') needs to snoop reports. It can't
rely on a bridge.
On the other hand, the current upstream implementation without
bridge support does not (necessarily) need it (will add an
explanation to the wiki page).
Though there is no (does not seem to be) any conceptual issue with
either the current upstream implementation or this proposition as is,
you just made me realize that there are issues with mixed setups...
backwards compatibility issues... For instance if node 'L' were of
a post-multicast but pre-multicast-bridge optimizations version.
next prev parent reply other threads:[~2014-11-26 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 5:42 [B.A.T.M.A.N.] [PATCHv9 0/4] Multicast optimizations for bridges Linus Lüssing
2014-09-07 5:42 ` [B.A.T.M.A.N.] [PATCHv9 1/4] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2014-09-07 5:42 ` [B.A.T.M.A.N.] [PATCHv9 2/4] batman-adv: Adding 'mcast' log level Linus Lüssing
2014-09-07 5:42 ` [B.A.T.M.A.N.] [PATCHv9 3/4] batman-adv: Add debugfs table for mcast flags Linus Lüssing
2014-09-07 5:42 ` [B.A.T.M.A.N.] [PATCHv9 4/4] batman-adv: Forward IGMP/MLD reports to selected querier (only) Linus Lüssing
2014-11-24 14:56 ` Simon Wunderlich
2014-11-26 16:37 ` Linus Lüssing [this message]
2014-11-23 16:14 ` [B.A.T.M.A.N.] [PATCHv9 0/4] Multicast optimizations for bridges Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126163743.GB3837@odroid \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox