b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 30/31] batman-adv: packet.h, add some missing includes
Date: Tue, 2 Dec 2014 16:30:40 +0100	[thread overview]
Message-ID: <20141202153040.GF24653@pengutronix.de> (raw)
In-Reply-To: <1869231.xPTQmY7LN2@sven-edge>

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

On Tue, Dec 02, 2014 at 03:09:52PM +0100, Sven Eckelmann wrote:
> On Tuesday 02 December 2014 14:57:03 Markus Pargmann wrote:
> > On Tue, Dec 02, 2014 at 02:03:16PM +0100, Sven Eckelmann wrote:
> > > Hi,
> > > 
> > > please explain how this file can now be used unmodified in userspace
> > > (batctl) and kernel. If it cannot be done without modifying the file then
> > > please provide patches to modify the daily checks which make sure that
> > > the files in both repos are the same. I think the batman-adv developers
> > > can give you the original scripts.
> > 
> > I wasn't aware that this file is also used in batctl. Why is it needed
> > there?
> > Probably I should have a look into the batctl sources.
> 
> It is used for things like the tcpdump, ping and traceroute. In the past (svn 
> times) it was just a links from batctl to batman-adv. But after the switch to 
> git it was decided that both should be kept in sync manually but checked 
> automatically.
> 
> I would like to give you the mini-check script but I don't have it. And I 
> don't have access to the servers anymore. But it is basically checkout of 
> master, maint and next of batctl+batman-adv and some calls to cmp (or diff?) 
> to check if both files are the same. A mail is sent [1] to a mailing list. 
> Someone has to merge the missing changes manually.

Thanks for the clarification. I will have a look at compile issues for
batctl. Until now I only worked with the batman tree imported into my
linux tree so all my kernel tools are still working.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-12-02 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 13:03 [B.A.T.M.A.N.] [PATCH 30/31] batman-adv: packet.h, add some missing includes Sven Eckelmann
2014-12-02 13:57 ` Markus Pargmann
2014-12-02 14:09   ` Sven Eckelmann
2014-12-02 15:30     ` Markus Pargmann [this message]
2014-12-02 16:22 ` Markus Pargmann
  -- strict thread matches above, loose matches on Subject: below --
2014-12-02 11:16 [B.A.T.M.A.N.] [PATCH 00/31] batman-adv: Cleanups Markus Pargmann
2014-12-02 11:16 ` [B.A.T.M.A.N.] [PATCH 30/31] batman-adv: packet.h, add some missing includes Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202153040.GF24653@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).