Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Add required to includes to all files

[Markus Pargmann <mpa@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

Hi Sven,

On Sun, Mar 22, 2015 at 03:51:17PM +0100, Sven Eckelmann wrote:
> The source and header files could not be build indepdent from each other. This
> is happened because headers didn't include all includes for anything they've
> used. This was problematic because the success of a build required to know the
> right order of local includes.
> 
> Also source files were not including everything they've used explicitly.
> Instead it required that transient includes are always stable. This is
> problematic because some transient includes are not obvious, depent on config
> settings and may not be stable in the future.
> 
> The order for include blocks are:
> 
>  * primary headers (main.h and the *.h file of a *.c file)
>  * global linux headers
>  * required local headers
>  * extra forward declarations for pointers in function/struct declarations

Thanks for your work. This patch looks really good.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]