From: David Miller <davem@davemloft.net>
To: linus.luessing@c0d3.blue
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
bridge@lists.linux-foundation.org
Subject: Re: [B.A.T.M.A.N.] [PATCH RFCv2 3/4] batman-adv: Forward IGMP/MLD reports to selected querier (only)
Date: Wed, 01 Apr 2015 13:44:31 -0400 (EDT) [thread overview]
Message-ID: <20150401.134431.1653220163353310062.davem@davemloft.net> (raw)
In-Reply-To: <1427875479-9240-4-git-send-email-linus.luessing@c0d3.blue>
From: Linus Lüssing <linus.luessing@c0d3.blue>
Date: Wed, 1 Apr 2015 10:04:38 +0200
> With this patch IGMP or MLD reports are only forwarded to the selected
> IGMP/MLD querier as RFC4541 suggests. This is necessary to avoid
> multicast packet loss in bridged scenarios later:
>
> An IGMPv2/MLDv1 querier does not actively join the multicast group the
> reports are sent to. Because of this, this leads to snooping
> bridges/switches not being able to learn of multicast listeners in the
> mesh and wrongly shutting down ports for multicast traffic to the mesh.
There is no way this is going to work.
First of all, you have no proper Kconfig dependencies upon IPV6, yet
you are calling these newly exported ipv6 multicast interfaces
unconditionally.
Even once you resolve that, you are going to run into problems in
situations where BATMAN_ADV=y and IPV6=m, for example.
next prev parent reply other threads:[~2015-04-01 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 8:04 [B.A.T.M.A.N.] [PATCH RFCv2 0/4] batman-adv: Unicasting multicast reports to querier-node only Linus Lüssing
2015-04-01 8:04 ` [B.A.T.M.A.N.] [PATCH RFCv2 1/4] bridge: multicast: call skb_checksum_{simple_, }validate Linus Lüssing
2015-04-01 8:04 ` [B.A.T.M.A.N.] [PATCH RFCv2 2/4] net: Export IGMP/MLD message validation code Linus Lüssing
2015-04-01 8:04 ` [B.A.T.M.A.N.] [PATCH RFCv2 3/4] batman-adv: Forward IGMP/MLD reports to selected querier (only) Linus Lüssing
2015-04-01 17:44 ` David Miller [this message]
2015-04-01 8:04 ` [B.A.T.M.A.N.] [PATCH RFCv2 4/4] batman-adv: Increase BATADV_TVLV_MCAST version number to 2 Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401.134431.1653220163353310062.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bridge@lists.linux-foundation.org \
--cc=linus.luessing@c0d3.blue \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).