public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix kerneldoc of main functions
Date: Sun, 1 Nov 2015 16:13:02 +0100	[thread overview]
Message-ID: <20151101151302.GA32213@pengutronix.de> (raw)
In-Reply-To: <1446290970-24053-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

Hi Sven,

On Sat, Oct 31, 2015 at 12:29:29PM +0100, Sven Eckelmann wrote:
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  net/batman-adv/bitarray.c       | 12 +++++++++---
>  net/batman-adv/bitarray.h       | 11 +++++------
>  net/batman-adv/debugfs.c        |  6 ++++++
>  net/batman-adv/main.c           |  2 ++
>  net/batman-adv/main.h           |  4 ++++
>  net/batman-adv/originator.c     |  4 +++-
>  net/batman-adv/packet.h         |  6 ++++++
>  net/batman-adv/routing.c        |  7 ++++++-
>  net/batman-adv/send.c           |  5 ++++-
>  net/batman-adv/soft-interface.c |  2 ++
>  net/batman-adv/sysfs.c          |  1 +
>  11 files changed, 48 insertions(+), 12 deletions(-)
> 
> diff --git a/net/batman-adv/bitarray.c b/net/batman-adv/bitarray.c
> index 06bab51..3404195 100644
> --- a/net/batman-adv/bitarray.c
> +++ b/net/batman-adv/bitarray.c
> @@ -29,10 +29,16 @@ static void batadv_bitmap_shift_left(unsigned long *seq_bits, s32 n)
>  	bitmap_shift_left(seq_bits, seq_bits, n, BATADV_TQ_LOCAL_WINDOW_SIZE);
>  }
>  
> -/* receive and process one packet within the sequence number window.
> +/**
> + * batadv_bit_get_packet - receive and process one packet within the sequence
> + *  number window

Are you sure this works? IIRC some time ago multi line function
descriptions were not supported.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-11-01 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31 11:28 [B.A.T.M.A.N.] [PATCH 0/2] Kerneldoc fixes and TODOs Sven Eckelmann
2015-10-31 11:29 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix kerneldoc of main functions Sven Eckelmann
2015-10-31 11:29   ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix kerneldoc of network-coding functions Sven Eckelmann
2015-11-17  7:34     ` Marek Lindner
2015-11-01 15:13   ` Markus Pargmann [this message]
2015-11-01 15:32     ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix kerneldoc of main functions Sven Eckelmann
2015-11-01 15:35       ` Markus Pargmann
2015-11-17  7:33   ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151101151302.GA32213@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox