Re: [B.A.T.M.A.N.] [PATCH v2 01/30] batman-adv: Fix list removal of batadv_hardif_neigh_node

Sven Eckelmann
2016-01-05T09:18:13Z

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

On Tuesday 05 January 2016 06:02:08 Linus Lüssing wrote:
> The whole patchset looks pretty good to me.
>
> Checked all patches for bugs but couldn't find any - could only
> find minor style issues.

Thanks for the review. I've already started to fix the stuff you found. I will
submit the new patchset (v4) later.

> Did not check:
>
> * Whether "Fixes:" tags match
> * How kref compares to atomic_t under the hood, whether it is
> currently basically the same or whether a switch fixes some bugs

kref is basically a wrapper around atomic_t. So it should not fix any bugs.

> PS: Just to clarify, patch 10 is only a style patch, right?

Yes, it is more a style patch to make everything more consistent.

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]