From: Antonio Quartulli <a@unstable.cc>
To: Andrew Lunn <andrew@lunn.ch>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Create batman soft interfaces within correct netns.
Date: Mon, 25 Jan 2016 11:28:53 +0800 [thread overview]
Message-ID: <20160125032853.GA15121@prodigo.lan> (raw)
In-Reply-To: <1453312110-32683-3-git-send-email-andrew@lunn.ch>
On Wed, Jan 20, 2016 at 06:48:28PM +0100, Andrew Lunn wrote:
> int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
> - const char *iface_name)
> + struct net *net, const char *iface_name)
Andrew,
minor style note here: instead of passing the namespace as argument, could we
just invoke dev_net() on hard_iface->net_dev inside
batadv_hardif_enable_interface() ?
> {
> struct batadv_priv *bat_priv;
> struct net_device *soft_iface, *master;
> @@ -432,10 +433,10 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
> if (!atomic_inc_not_zero(&hard_iface->refcount))
> goto out;
>
> - soft_iface = dev_get_by_name(&init_net, iface_name);
> + soft_iface = dev_get_by_name(net, iface_name);
>
> if (!soft_iface) {
> - soft_iface = batadv_softif_create(iface_name);
> + soft_iface = batadv_softif_create(net, iface_name);
>
> if (!soft_iface) {
> ret = -ENOMEM;
--
Antonio Quartulli
next prev parent reply other threads:[~2016-01-25 3:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:48 [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Andrew Lunn
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves Andrew Lunn
2016-01-23 2:06 ` Antonio Quartulli
2016-01-23 17:20 ` Andrew Lunn
2016-01-24 6:19 ` Antonio Quartulli
2016-01-24 10:42 ` Antonio Quartulli
2016-01-24 16:46 ` Andrew Lunn
2016-01-24 11:01 ` Antonio Quartulli
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Create batman soft interfaces within correct netns Andrew Lunn
2016-01-25 3:28 ` Antonio Quartulli [this message]
2016-01-25 13:12 ` Andrew Lunn
2016-01-26 5:43 ` Antonio Quartulli
2016-01-26 5:55 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-01-26 12:53 ` Antonio Quartulli
2016-01-26 13:25 ` Sven Eckelmann
2016-01-27 10:13 ` Sven Eckelmann
2016-01-27 10:44 ` Antonio Quartulli
2016-02-01 2:57 ` Antonio Quartulli
2016-02-02 2:11 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: debugfs: Add netns support Andrew Lunn
2016-01-28 1:28 ` Antonio Quartulli
2016-01-28 1:40 ` Andrew Lunn
2016-01-28 2:29 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-28 2:59 ` [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Antonio Quartulli
2016-01-28 3:50 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann
2016-02-12 15:57 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125032853.GA15121@prodigo.lan \
--to=a@unstable.cc \
--cc=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox