Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Create batman soft interfaces within correct netns.

Antonio Quartulli
2016-01-26T05:43:14Z

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Mon, Jan 25, 2016 at 02:12:39PM +0100, Andrew Lunn wrote:
> On Mon, Jan 25, 2016 at 11:28:53AM +0800, Antonio Quartulli wrote:
> > On Wed, Jan 20, 2016 at 06:48:28PM +0100, Andrew Lunn wrote:
> > > int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
> > > - const char *iface_name)
> > > + struct net *net, const char *iface_name)
> >
> > Andrew,
> > minor style note here: instead of passing the namespace as argument, could we
> > just invoke dev_net() on hard_iface->net_dev inside
> > batadv_hardif_enable_interface() ?
>
> Hi Antonio
>
> The problem with that is register_netdevice() is used to register the
> soft interface in batadv_softif_create(). Calling it after
> registrations would mean it needs to change netns. The default
> namespace might already have a bat0, so it is given the name bat1, but
> then gets moved to the target netns, and will keeps its name, unless
> there already is a bat1 interface. But people expect the newly created
> interface to be called bat0.
>
> I think passing the namespace is correct, so the softif can be created
> in the correct place to start with.
>

Yeah, you are right, I overlooked something in my review.
The patch looks good to me.

Cheers,

--
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]