From: Antonio Quartulli <a@unstable.cc>
To: Andrew Lunn <andrew@lunn.ch>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Handle parent interfaces in a different netns
Date: Tue, 26 Jan 2016 20:53:14 +0800 [thread overview]
Message-ID: <20160126125314.GA25892@prodigo> (raw)
In-Reply-To: <1453312110-32683-4-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On Wed, Jan 20, 2016 at 06:48:29PM +0100, Andrew Lunn wrote:
> /**
> + * batadv_mutual_parents - check if two devices are each others parent
> + * @net_dev - 1st parent
> + * @parent_dev - 2nd parent
> + *
> + * veth devices come in pairs and each is the parent of the other!
> + *
> + * Return true if the devices are each others parent, otherwise false
Andrew, minor style issue: you should put the ':' after the word Return.
Please check the other comments in this file as example. Sven recently changed
all the comments to be coherent with this style.
Other than this, the patch looks good to me.
You can add my
Acked-by: Antonio Quartulli <a@untable.cc>
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-26 12:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:48 [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Andrew Lunn
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves Andrew Lunn
2016-01-23 2:06 ` Antonio Quartulli
2016-01-23 17:20 ` Andrew Lunn
2016-01-24 6:19 ` Antonio Quartulli
2016-01-24 10:42 ` Antonio Quartulli
2016-01-24 16:46 ` Andrew Lunn
2016-01-24 11:01 ` Antonio Quartulli
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Create batman soft interfaces within correct netns Andrew Lunn
2016-01-25 3:28 ` Antonio Quartulli
2016-01-25 13:12 ` Andrew Lunn
2016-01-26 5:43 ` Antonio Quartulli
2016-01-26 5:55 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-01-26 12:53 ` Antonio Quartulli [this message]
2016-01-26 13:25 ` Sven Eckelmann
2016-01-27 10:13 ` Sven Eckelmann
2016-01-27 10:44 ` Antonio Quartulli
2016-02-01 2:57 ` Antonio Quartulli
2016-02-02 2:11 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: debugfs: Add netns support Andrew Lunn
2016-01-28 1:28 ` Antonio Quartulli
2016-01-28 1:40 ` Andrew Lunn
2016-01-28 2:29 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-28 2:59 ` [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Antonio Quartulli
2016-01-28 3:50 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann
2016-02-12 15:57 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126125314.GA25892@prodigo \
--to=a@unstable.cc \
--cc=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox