From: Antonio Quartulli <a@unstable.cc>
To: Sven Eckelmann <sven@narfation.org>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Check skb size before using encapsulated ETH+VLAN header
Date: Sun, 28 Feb 2016 17:42:21 +0800 [thread overview]
Message-ID: <20160228094221.GL28478@prodigo> (raw)
In-Reply-To: <2289020.8mL0hEvS8q@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Sun, Feb 28, 2016 at 10:20:30AM +0100, Sven Eckelmann wrote:
> Ok, I misunderstood his comment. This one is not necessary when each path to
> this function uses batadv_check_unicast_packet or does "if
> (!pskb_may_pull(skb, hdr_size))" directly. The only callers are
> batadv_recv_bcast_packet (does "if (unlikely(!pskb_may_pull(skb, hdr_size)))")
> and batadv_recv_unicast_packet (calls batadv_check_unicast_packet). I would
> say that an extra patch for that can be introduced later to remove it. But it
> should not be part of this patch because this fix should not contain cleanup
> stuff ("batman-adv header size check") which is not related to the
> encapsulated ethernet (vlan) header.
True.
Better to keep the fix small and address that in a later patch.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-28 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 16:56 [B.A.T.M.A.N.] [PATCH] batman-adv: Check skb size before using encapsulated ETH+VLAN header Sven Eckelmann
2016-02-28 0:49 ` Marek Lindner
2016-02-28 6:36 ` Sven Eckelmann
2016-02-28 9:02 ` Antonio Quartulli
2016-02-28 9:20 ` Sven Eckelmann
2016-02-28 9:42 ` Antonio Quartulli [this message]
2016-03-20 9:57 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228094221.GL28478@prodigo \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox