Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Check skb size before using encapsulated ETH+VLAN header

Antonio Quartulli
2016-02-28T09:42:21Z

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Sun, Feb 28, 2016 at 10:20:30AM +0100, Sven Eckelmann wrote:
> Ok, I misunderstood his comment. This one is not necessary when each path to
> this function uses batadv_check_unicast_packet or does "if
> (!pskb_may_pull(skb, hdr_size))" directly. The only callers are
> batadv_recv_bcast_packet (does "if (unlikely(!pskb_may_pull(skb, hdr_size)))")
> and batadv_recv_unicast_packet (calls batadv_check_unicast_packet). I would
> say that an extra patch for that can be introduced later to remove it. But it
> should not be part of this patch because this fix should not contain cleanup
> stuff ("batman-adv header size check") which is not related to the
> encapsulated ethernet (vlan) header.

True.
Better to keep the fix small and address that in a later patch.

Cheers,

--
Antonio Quartulli

[-- Attachment #2: Digital signature --]