[B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Antonio Quartulli]

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 net/batman-adv/distributed-arp-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index 919a8d2..ab79f3a 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -717,7 +717,7 @@ void batadv_dat_status_update(struct net_device *net_dev)
 }
 
 /**
- * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
+ * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
  * @bat_priv: the bat priv with all the soft interface information
  * @orig: the orig_node of the ogm
  * @flags: flags indicating the tvlv state (see batadv_tvlv_handler_flags)
-- 
2.7.2

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 7127 bytes --]

On Wednesday 09 March 2016 08:55:19 Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>  net/batman-adv/distributed-arp-table.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/batman-adv/distributed-arp-table.c
> b/net/batman-adv/distributed-arp-table.c index 919a8d2..ab79f3a 100644
> --- a/net/batman-adv/distributed-arp-table.c
> +++ b/net/batman-adv/distributed-arp-table.c
> @@ -717,7 +717,7 @@ void batadv_dat_status_update(struct net_device
> *net_dev) }
> 
>  /**
> - * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> + * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
>   * @bat_priv: the bat priv with all the soft interface information
>   * @orig: the orig_node of the ogm
>   * @flags: flags indicating the tvlv state (see batadv_tvlv_handler_flags)

You've missed some (see
https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc48fe58ac3551b3
for the update patch):

diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index 642167f..f0075ff 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -1576,7 +1576,7 @@ bool batadv_bla_is_backbone_gw(struct sk_buff *skb,
 }
 
 /**
- * batadv_bla_init - free all bla structures
+ * batadv_bla_free - free all bla structures
  * @bat_priv: the bat priv with all the soft interface information
  *
  * for softinterface free or module unload
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index 919a8d2..ab79f3a 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -717,7 +717,7 @@ void batadv_dat_status_update(struct net_device *net_dev)
 }
 
 /**
- * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
+ * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
  * @bat_priv: the bat priv with all the soft interface information
  * @orig: the orig_node of the ogm
  * @flags: flags indicating the tvlv state (see batadv_tvlv_handler_flags)
diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c
index 14d0013..df449a0 100644
--- a/net/batman-adv/icmp_socket.c
+++ b/net/batman-adv/icmp_socket.c
@@ -337,7 +337,7 @@ err:
 }
 
 /**
- * batadv_socket_receive_packet - schedule an icmp packet to be sent to
+ * batadv_socket_add_packet - schedule an icmp packet to be sent to
  *  userspace on an icmp socket.
  * @socket_client: the socket this packet belongs to
  * @icmph: pointer to the header of the icmp packet
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index e602408..1565df0 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -296,7 +296,8 @@ static inline bool batadv_compare_eth(const void *data1, const void *data2)
 }
 
 /**
- * has_timed_out - compares current time (jiffies) and timestamp + timeout
+ * batadv_has_timed_out - compares current time (jiffies) and timestamp +
+ *  timeout
  * @timestamp:		base value to compare with (in jiffies)
  * @timeout:		added to base value before comparing (in milliseconds)
  *
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
index 8caa2c7..c32f24f 100644
--- a/net/batman-adv/multicast.c
+++ b/net/batman-adv/multicast.c
@@ -394,7 +394,8 @@ static int batadv_mcast_forw_mode_check(struct batadv_priv *bat_priv,
 }
 
 /**
- * batadv_mcast_want_all_ip_count - count nodes with unspecific mcast interest
+ * batadv_mcast_forw_want_all_ip_count - count nodes with unspecific mcast
+ *  interest
  * @bat_priv: the bat priv with all the soft interface information
  * @ethhdr: ethernet header of a packet
  *
@@ -433,7 +434,7 @@ batadv_mcast_forw_tt_node_get(struct batadv_priv *bat_priv,
 }
 
 /**
- * batadv_mcast_want_forw_ipv4_node_get - get a node with an ipv4 flag
+ * batadv_mcast_forw_ipv4_node_get - get a node with an ipv4 flag
  * @bat_priv: the bat priv with all the soft interface information
  *
  * Return: an orig_node which has the BATADV_MCAST_WANT_ALL_IPV4 flag set and
@@ -460,7 +461,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv)
 }
 
 /**
- * batadv_mcast_want_forw_ipv6_node_get - get a node with an ipv6 flag
+ * batadv_mcast_forw_ipv6_node_get - get a node with an ipv6 flag
  * @bat_priv: the bat priv with all the soft interface information
  *
  * Return: an orig_node which has the BATADV_MCAST_WANT_ALL_IPV6 flag set
@@ -487,7 +488,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv)
 }
 
 /**
- * batadv_mcast_want_forw_ip_node_get - get a node with an ipv4/ipv6 flag
+ * batadv_mcast_forw_ip_node_get - get a node with an ipv4/ipv6 flag
  * @bat_priv: the bat priv with all the soft interface information
  * @ethhdr: an ethernet header to determine the protocol family from
  *
@@ -511,7 +512,7 @@ batadv_mcast_forw_ip_node_get(struct batadv_priv *bat_priv,
 }
 
 /**
- * batadv_mcast_want_forw_unsnoop_node_get - get a node with an unsnoopable flag
+ * batadv_mcast_forw_unsnoop_node_get - get a node with an unsnoopable flag
  * @bat_priv: the bat priv with all the soft interface information
  *
  * Return: an orig_node which has the BATADV_MCAST_WANT_ALL_UNSNOOPABLES flag
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index e63d6a5..84d5a1e 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -289,7 +289,7 @@ void batadv_neigh_node_put(struct batadv_neigh_node *neigh_node)
 }
 
 /**
- * batadv_orig_node_get_router - router to the originator depending on iface
+ * batadv_orig_router_get - router to the originator depending on iface
  * @orig_node: the orig node for the router
  * @if_outgoing: the interface where the payload packet has been received or
  *  the OGM should be sent to
diff --git a/net/batman-adv/packet.h b/net/batman-adv/packet.h
index 8a8d7ca..0796dfd 100644
--- a/net/batman-adv/packet.h
+++ b/net/batman-adv/packet.h
@@ -501,7 +501,7 @@ struct batadv_coded_packet {
 #pragma pack()
 
 /**
- * struct batadv_unicast_tvlv - generic unicast packet with tvlv payload
+ * struct batadv_unicast_tvlv_packet - generic unicast packet with tvlv payload
  * @packet_type: batman-adv packet type, part of the general header
  * @version: batman-adv protocol version, part of the genereal header
  * @ttl: time to live for this packet, part of the genereal header
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 7679f3a..bae24c0 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -539,7 +539,7 @@ struct batadv_softif_vlan *batadv_softif_vlan_get(struct batadv_priv *bat_priv,
 }
 
 /**
- * batadv_create_vlan - allocate the needed resources for a new vlan
+ * batadv_softif_create_vlan - allocate the needed resources for a new vlan
  * @bat_priv: the bat priv with all the soft interface information
  * @vid: the VLAN identifier
  *

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

On Wed, Mar 09, 2016 at 10:11:43PM +0100, Sven Eckelmann wrote:
> On Wednesday 09 March 2016 08:55:19 Antonio Quartulli wrote:
> > Signed-off-by: Antonio Quartulli <a@unstable.cc>
> > ---
> >  net/batman-adv/distributed-arp-table.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/batman-adv/distributed-arp-table.c
> > b/net/batman-adv/distributed-arp-table.c index 919a8d2..ab79f3a 100644
> > --- a/net/batman-adv/distributed-arp-table.c
> > +++ b/net/batman-adv/distributed-arp-table.c
> > @@ -717,7 +717,7 @@ void batadv_dat_status_update(struct net_device
> > *net_dev) }
> > 
> >  /**
> > - * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > + * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> >   * @bat_priv: the bat priv with all the soft interface information
> >   * @orig: the orig_node of the ogm
> >   * @flags: flags indicating the tvlv state (see batadv_tvlv_handler_flags)
> 
> You've missed some (see
> https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc48fe58ac3551b3
> for the update patch):

May I resend this patch with your sign-off as well ?

Cheers,

-- 
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

On Thursday 10 March 2016 09:15:45 Antonio Quartulli wrote:
> > You've missed some (see
> > https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc
> > 48fe58ac3551b3
> > for the update patch):
> May I resend this patch with your sign-off as well ?

Yes:

https://git.open-mesh.org/batman-adv.git/commit/3d70bed1c1504d67174def5a1bef54053185889b

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On Thursday, March 10, 2016 09:15:45 Antonio Quartulli wrote:
> > > - * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > > + * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > >
> > >   * @bat_priv: the bat priv with all the soft interface information
> > >   * @orig: the orig_node of the ogm
> > >   * @flags: flags indicating the tvlv state (see
> > >batadv_tvlv_handler_flags)>
> > 
> >
> > You've missed some (see
> > https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc
> > 48fe58ac3551b3
> > for the update patch):
> May I resend this patch with your sign-off as well ?

Is that updated patch yet to come ?

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

On Monday 28 March 2016 22:30:12 Marek Lindner wrote:
[...]
> > May I resend this patch with your sign-off as well ?
> 
> Is that updated patch yet to come ?

https://patchwork.open-mesh.org/patch/15911/

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On Mon, Mar 28, 2016 at 10:30:12PM +0800, Marek Lindner wrote:
> On Thursday, March 10, 2016 09:15:45 Antonio Quartulli wrote:
> > > > - * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > > > + * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > > >
> > > >   * @bat_priv: the bat priv with all the soft interface information
> > > >   * @orig: the orig_node of the ogm
> > > >   * @flags: flags indicating the tvlv state (see
> > > >batadv_tvlv_handler_flags)>
> > > 
> > >
> > > You've missed some (see
> > > https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc
> > > 48fe58ac3551b3
> > > for the update patch):
> > May I resend this patch with your sign-off as well ?
> 
> Is that updated patch yet to come ?

Yes. Will land shortly.

Cheers,


-- 
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix typ0 in kerneldoc

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

On Mon, Mar 28, 2016 at 10:57:34PM +0800, Antonio Quartulli wrote:
> On Mon, Mar 28, 2016 at 10:30:12PM +0800, Marek Lindner wrote:
> > On Thursday, March 10, 2016 09:15:45 Antonio Quartulli wrote:
> > > > > - * batadv_gw_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > > > > + * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container
> > > > >
> > > > >   * @bat_priv: the bat priv with all the soft interface information
> > > > >   * @orig: the orig_node of the ogm
> > > > >   * @flags: flags indicating the tvlv state (see
> > > > >batadv_tvlv_handler_flags)>
> > > > 
> > > >
> > > > You've missed some (see
> > > > https://git.open-mesh.org/batman-adv.git/commit/94399934a5e050073e1146ecfc
> > > > 48fe58ac3551b3
> > > > for the update patch):
> > > May I resend this patch with your sign-off as well ?
> > 
> > Is that updated patch yet to come ?
> 
> Yes. Will land shortly.

Actually Sven took care of this already. Thanks Sven!

Cheers,



-- 
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]