Re: [B.A.T.M.A.N.] [PATCH v3 6/6] batman-adv: debugfs: Add netns support

Sven Eckelmann
2016-03-14T10:57:40Z

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

On Sunday 13 March 2016 19:50:34 Sven Eckelmann wrote:
> From: Andrew Lunn <andrew@lunn.ch>
>
> Unlike sysfs, debugfs is not netns aware. So batman has to take care
> to avoid namespace clashes.
>
> Each namespace is given a directory within debugfs/batman-adv/netns,
> using the namespaces inum as the directory name.
>
> Files for namespaces other than the global namespace are placed within
> the namespace specific directory. Additionally, a symbolic link is
> used to link the global namespaces inum back to debugfs/batman-adv/ so
> tools do not need to differentiate between the global namespace and
> other namespaces.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> compat-patches/0002-ns.inum.patch | 25 ++++++++
> net/batman-adv/debugfs.c | 130 +++++++++++++++++++++++++++++++++++++-
> 2 files changed, 152 insertions(+), 3 deletions(-)
> create mode 100644 compat-patches/0002-ns.inum.patch

Matthias is against applying [1] patch 6 because it would require that
batman-adv supports this interface for a long(tm) time. He proposes to use
netlink instead.

Andrew, do you want to change patch 6 to avoid creating the debugfs stuff in
non-init_net netns?

Kind regards,
Sven

[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014690.html

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]