public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "B.A.T.M.A.N" <b.a.t.m.a.n@lists.open-mesh.net>
Subject: [B.A.T.M.A.N.] skb->priority and fragments
Date: Tue, 12 Apr 2016 22:42:59 +0200	[thread overview]
Message-ID: <20160412204259.GK29895@lunn.ch> (raw)

Hi Folks

Does anybody remember the history for the follow and can explain why
the code is as it is?

The soft interface transmit function, batadv_interface_tx() calls
batadv_skb_set_priority(skb, 0) to set the skb->priority based on the
TOS bits or 801.p.

If the packet needs to be fragmented because of MTU issues,
batadv_frag_create() is used to create the fragments. It overwrites
the skb->priority in the original skb to TC_PRIO_CONTROL, and leaves
the fragment skb with the default priority.

This seems a bit odd to me. I would of expected the priority to of
been copied from the original into the fragment.

Thanks
	Andrew

             reply	other threads:[~2016-04-12 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 20:42 Andrew Lunn [this message]
2016-04-13 11:11 ` [B.A.T.M.A.N.] skb->priority and fragments Simon Wunderlich
2016-04-13 12:14   ` Andrew Lunn
2016-04-13 12:19     ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160412204259.GK29895@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox