From: Antonio Quartulli <antonio.quartulli@open-mesh.com>
To: Sven Eckelmann <sven.eckelmann@open-mesh.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v2 3/3] batman-adv: throughput meter implementation
Date: Tue, 3 May 2016 20:21:31 +0800 [thread overview]
Message-ID: <20160503122131.GC11201@prodigo.lan> (raw)
In-Reply-To: <17410440.33Me94yB3F@bentobox>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, May 03, 2016 at 10:18:50AM +0200, Sven Eckelmann wrote:
> On Tuesday 03 May 2016 01:28:28 Antonio Quartulli wrote:
> [...]
> > shouldn't we propagate the value saved in err to tp_vars->reason ?
> >
> > We found this error while using the tp_meter, because we tried to run it
> > against a non-existing originator and batctl crashed.
>
> Yes, looks like I've missed this while reviewing your tp_meter code. Was
> the crash something like:
>
> root@node02:~# /host/batctl/batctl tp 02:ba:de:af:ff:01
> Throughput meter called towards 02:ba:de:af:ff:01
> tp_meter.c:198:36: runtime error: division by zero
> traps: batctl[246] trap divide error ip:410f31 sp:7ffea78512c0 error:0 in batctl[400000+18000]
> Floating point exception
exactly the same.
>
> I will most likely add code catching it in both batctl and batman-adv.
Thanks !
Cheers,
--
Antonio Quartulli
Director of Embedded Software | Open Mesh, Inc.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-03 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 10:54 [B.A.T.M.A.N.] [PATCH v2 1/3] batman-adv: return netdev status in the TX path Sven Eckelmann
2016-04-01 10:54 ` [B.A.T.M.A.N.] [PATCH v2 2/3] batman-adv: use another ICMP packet when sending command from userspace Sven Eckelmann
2016-04-01 10:54 ` [B.A.T.M.A.N.] [PATCH v2 3/3] batman-adv: throughput meter implementation Sven Eckelmann
2016-05-02 17:28 ` Antonio Quartulli
2016-05-03 8:18 ` Sven Eckelmann
2016-05-03 12:21 ` Antonio Quartulli [this message]
2016-05-02 17:53 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503122131.GC11201@prodigo.lan \
--to=antonio.quartulli@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven.eckelmann@open-mesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox