Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

Marek Lindner
2016-05-03T20:16:23Z

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Tuesday, May 03, 2016 14:20:46 Andrew Lunn wrote:
> On Tue, May 03, 2016 at 09:07:35AM +0200, Sven Eckelmann wrote:
> > [...]
> >
> > > +ifeq ($(origin LIBNL_GENL_CFLAGS) $(origin LIBNL_GENL_LDLIBS),
> > > undefined undefined) + LIBNL_GENL_NAME ?= libnl-genl-3.0
> > > + ifeq ($(shell $(PKG_CONFIG) --modversion $(LIBNL_GENL_NAME)
> > > 2>/dev/null),) + $(error No $(LIBNL_GENL_NAME) development libraries
> > > found!)
> > > + endif
> > > + LIBNL_GENL_CFLAGS += $(shell $(PKG_CONFIG) --cflags
> > > $(LIBNL_GENL_NAME))
> > > + LIBNL_GENL_LDLIBS += $(shell $(PKG_CONFIG) --libs $(LIBNL_GENL_NAME))
> > > +endif
> > > +CFLAGS += $(LIBNL_GENL_CFLAGS)
> > > +LDLIBS += $(LIBNL_GENL_LDLIBS)
> >
> >
> >
> > @Simon, @Matthias, @Antonio, @Marek: Should the header file be included in
> > batctl like nl80211.h in iw. Or should we always require the current
> > kernel
> > header files installed to build batctl?
>
> Once the code is mostly complete and stable, i think a local copy
> would be good. It does seems to be the common way.

A local copy sounds like a sensible choice and common practice.

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]