From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: replace dev->trans_start update with helper
Date: Thu, 5 May 2016 20:06:20 +0800 [thread overview]
Message-ID: <20160505120413.GN11201@prodigo.lan> (raw)
In-Reply-To: <1726573.p6gE20s2JI@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Thu, May 05, 2016 at 12:36:54PM +0200, Sven Eckelmann wrote:
> On Thursday 05 May 2016 18:04:35 Antonio Quartulli wrote:
> [...]
> > >
> > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 7, 0)
> > > +
> > > +#define netif_trans_update batadv_netif_trans_update
> > > +static inline void batadv_netif_trans_update(struct net_device *dev)
> >
> > Sven,
> >
> > do we really need to rename the function is the original one does not exist
> > in kernels < 4.7 ? Or maybe it exists but does something else ?
>
> Not necessarily but Linus' noticed for a different function that some distros
> (or stable maintainers) backported the function which we introduced. Thus we
> used the same trick to solve the conflict.
Yup, thanks for reminding!
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-05 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 7:44 [B.A.T.M.A.N.] [PATCH next] batman-adv: replace dev->trans_start update with helper Sven Eckelmann
2016-05-05 10:04 ` Antonio Quartulli
2016-05-05 10:36 ` Sven Eckelmann
2016-05-05 12:06 ` Antonio Quartulli [this message]
2016-05-05 10:06 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505120413.GN11201@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox