public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v3] batman-adv: use static string for table headers
Date: Thu, 5 May 2016 22:47:27 +0800	[thread overview]
Message-ID: <20160505144727.GO11201@prodigo.lan> (raw)
In-Reply-To: <2831615.2xmdSus33c@voltaire>

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Tue, Apr 12, 2016 at 12:04:06AM +0800, Marek Lindner wrote:
> On Saturday, March 12, 2016 10:30:18 Sven Eckelmann wrote:
> > From: Antonio Quartulli <a@unstable.cc>
> > 
> > Use a static string when showing table headers rather then
> > a nonsense parametric one with fixed arguments.
> > 
> > It is easier to grep and it does not need to be recomputed
> > at runtime each time.
> > 
> > Reported-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Antonio Quartulli <a@unstable.cc>
> > [sven@narfation.org: fix conflicts with current version]
> > Signed-off-by: Sven Eckelmann <sven@narfation.org>
> > ---
> > v3:
> >  - workaround checkpatch error (over 80 chars) caused by __stringify
> > v2:
> >  - rebased patch
> >  - added new static strings in bat_v.c and bat_iv_ogm.c
> > 
> > Patch was resurrected from https://patchwork.open-mesh.org/patch/3599/
> > 
> > I've requested an rebased version at
> > https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014637.html
> > but done it myself because it was rather trivial.
> > ---
> >  net/batman-adv/bat_iv_ogm.c            | 8 +++-----
> >  net/batman-adv/bat_v.c                 | 9 ++++-----
> >  net/batman-adv/bridge_loop_avoidance.c | 7 +++----
> >  net/batman-adv/distributed-arp-table.c | 4 ++--
> >  net/batman-adv/translation-table.c     | 9 ++++-----
> >  5 files changed, 16 insertions(+), 21 deletions(-)
> 
> Applied in revision f7be1df.

The Gateway table was missed here ..

Cheers,


-- 
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-05-05 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12  9:30 [B.A.T.M.A.N.] [PATCH v3] batman-adv: use static string for table headers Sven Eckelmann
2016-04-11 16:04 ` Marek Lindner
2016-05-05 14:47   ` Antonio Quartulli [this message]
2016-05-05 15:10     ` Sven Eckelmann
2016-05-05 15:12       ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160505144727.GO11201@prodigo.lan \
    --to=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox