Re: [B.A.T.M.A.N.] [PATCH v3] batman-adv: use static string for table headers

Marek Lindner
2016-04-11T16:04:06Z

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

On Saturday, March 12, 2016 10:30:18 Sven Eckelmann wrote:
> From: Antonio Quartulli <a@unstable.cc>
>
> Use a static string when showing table headers rather then
> a nonsense parametric one with fixed arguments.
>
> It is easier to grep and it does not need to be recomputed
> at runtime each time.
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> [sven@narfation.org: fix conflicts with current version]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v3:
> - workaround checkpatch error (over 80 chars) caused by __stringify
> v2:
> - rebased patch
> - added new static strings in bat_v.c and bat_iv_ogm.c
>
> Patch was resurrected from https://patchwork.open-mesh.org/patch/3599/
>
> I've requested an rebased version at
> https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014637.html
> but done it myself because it was rather trivial.
> ---
> net/batman-adv/bat_iv_ogm.c | 8 +++-----
> net/batman-adv/bat_v.c | 9 ++++-----
> net/batman-adv/bridge_loop_avoidance.c | 7 +++----
> net/batman-adv/distributed-arp-table.c | 4 ++--
> net/batman-adv/translation-table.c | 9 ++++-----
> 5 files changed, 16 insertions(+), 21 deletions(-)

Applied in revision f7be1df.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]